Repository navigation
feat(generative): add location setting to generative-google config - #476
Open
OsamaAnsar wants to merge 2 commits into
Open
OsamaAnsar wants to merge 2 commits into
OsamaAnsar wants to merge 2 commits into
Conversation
Contributor
Author
|
I agree with the CLA |
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #445.
Adds the optional
locationsetting to thegenerative-googlemodule (defaults tous-central1server-side). Mirrors weaviate-python-client#2118 / #2130.Approach
locationis a plain pass-through field on both existinggenerative-googleconfig surfaces, so no builder logic changes are needed:configure.generative.google()already spreads...config, so addinglocationtoGenerativeGoogleConfigis enough.generativeParameters.google()already spreads...rest, and the vendoredGenerativeGoogleproto message already carrieslocation(src/proto/v1/generative.ts), so addinglocationtoGenerativeGoogleConfigRuntimecompletes the runtime path without touchingserialize/index.ts.Changes
src/collections/config/types/generative.ts—location?: stringonGenerativeGoogleConfigsrc/collections/types/generate.ts—location?: stringonGenerativeGoogleConfigRuntimesrc/collections/configure/unit.test.ts—locationadded to the existinggenerative.googleall-values testNo new test in
generate/unit.test.ts: per that file's header comment it only covers fields that are renamed to a gRPC name, andlocationpasses through unchanged.Testing
npx tsc --noEmitclean.eslintandprettier --checkclean. Unit suite passes (160/160 acrossconfigure/unit.test.ts+generate/unit.test.ts) withWEAVIATE_VERSIONset locally fortest/version.ts.