Repository navigation
fix(media): strip data URI prefix from base64 media strings - #489
Open
jackiectl2 wants to merge 1 commit into
Open
jackiectl2 wants to merge 1 commit into
jackiectl2 wants to merge 1 commit into
Conversation
toBase64FromMedia passed strings like `data:image/jpeg;base64,<data>` on unchanged. The web client sent the prefix to Weaviate, which rejects it, and the node client treated the string as a file path or URL, so it failed with ENOENT or "Failed to download image from URL". Detect a `data:<mime>;base64,` prefix and return only the base64 payload, as the v2 GraphQL nearMedia builder already does. Signed-off-by: Tianlang (Jackie) Chen <305351710+jackiectl2@users.noreply.github.com>
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #250
What
toBase64FromMedianow accepts base64 data URIs such asdata:image/jpeg;base64,<data>(e.g. the output ofFileReader.readAsDataURLorcanvas.toDataURL) and sends only the base64 payload to Weaviate, in both@weaviate/nodeand@weaviate/web. This applies everywhere media goes throughtoBase64FromMedia:nearImage/nearMediain query, generate and aggregate, and generativeimages.Why
data:were returned unchanged, so the prefix was sent to the server and the request failed.fs.statfirst, so a short data URI failed withENOENT; a long one hitENAMETOOLONG, was then treated as a URL, and failed withFailed to download image from URL.The v2 GraphQL
nearMediabuilder already strips this prefix; this does the same for the collections API. Non-base64data:strings keep their current behaviour.Testing
packages/test/node/base64/unit.test.ts(via the public@weaviate/nodeexport) andpackages/test/web/base64.test.ts. They fail without the change.npm run lint,npm run format:check,npm run build(incl.check:web) and all unit tests inpackages/testpass locally.