Repository navigation
Conversation
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
claude-haiku-5-5 returns a leading thinking block, which the server's generative-anthropic module currently reads as empty text.
bevzzz
requested changes
Nov 5, 2026
Comment on lines
+30
to
+36
| // Claude 4.7 and later models reject them with an error, and some | ||
| // earlier models reject Temperature and TopP set together. | ||
| // Leave them unset unless the target model accepts them. | ||
| // | ||
| // See [Anthropic Docs - Messages API]. | ||
| // | ||
| // [Anthropic Docs - Messages API]: https://platform.claude.com/docs/en/build-with-claude/working-with-messages |
Collaborator
There was a problem hiding this comment.
suggestion: looks like this is something that is better left for Weaviate Docs to clarify. E.g. Claude 4.7 and later models rejects Temaperature with an error is not client's behavior.
Comment on lines
+37
to
+39
| Temperature *float64 `json:"temperature,omitempty"` | ||
| TopK *int64 `json:"topK,omitempty"` | ||
| TopP *float64 `json:"topP,omitempty"` |
Collaborator
There was a problem hiding this comment.
Suggested change
| Temperature *float64 `json:"temperature,omitempty"` | |
| TopK *int64 `json:"topK,omitempty"` | |
| TopP *float64 `json:"topP,omitempty"` | |
| Temperature *float64 `json:"temperature,omitzero"` | |
| TopK *int64 `json:"topK,omitzero"` | |
| TopP *float64 `json:"topP,omitzero"` |
question: is 0 a reasonable value for any of these parameters? If not, I'd suggest using a primitive type instead and adding omitzero tag. Same goes for MaxTokens above.
| type Provider struct { | ||
| // Images are base64-encoded images passed to the model with the prompt. | ||
| Images []string | ||
| // ImageProperties name the object properties that contain images for the prompt. |
Collaborator
There was a problem hiding this comment.
Suggested change
| // ImageProperties name the object properties that contain images for the prompt. | |
| // ImageProperties lists the object properties that contain images for the prompt. |
nit: imo "name" here is a claudism, "pseudo-elevated diction" as the source describes it
| type Generative struct { | ||
| // BaseURL overrides the default request URL, e.g. a proxy. | ||
| BaseURL string `json:"baseURL,omitempty"` | ||
| // Model is the Anthropic model name, e.g. "claude-haiku-4-5". |
Collaborator
There was a problem hiding this comment.
Suggested change
| // Model is the Anthropic model name, e.g. "claude-haiku-4-5". | |
| // Model name. |
nit: the example value is redundant here, as all modules which have .Model field expect the same kind of input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.