feat: add disconnect on event source wrapper#367
Open
clarkdo wants to merge 1 commit into
Open
Conversation
Contributor
|
This code appears correct, but could you describe a use-case which would motivate doing this? |
Author
|
My case is that I want to close connection if the browser tab is hidden or minimized and refresh page when tab gets activated again for preventing reaching connection limitations. |
bjohansebas
added a commit
to webpack/webpack-dev-middleware
that referenced
this pull request
Jul 20, 2026
Expose a way to close the EventSource for the current path and stop the reconnection watchdog (e.g. before tearing the page down). The cached wrapper is dropped so a later setOptionsAndConnect() opens a fresh connection. Ref webpack/webpack-hot-middleware#367
bjohansebas
added a commit
to webpack/webpack-dev-middleware
that referenced
this pull request
Jul 20, 2026
* feat(client): add disconnect() to close the SSE connection Expose a way to close the EventSource for the current path and stop the reconnection watchdog (e.g. before tearing the page down). The cached wrapper is dropped so a later setOptionsAndConnect() opens a fresh connection. Ref webpack/webpack-hot-middleware#367 * fixup!
Member
|
webpack-hot-middleware is being migrated into webpack-dev-middleware — see webpack/webpack-dev-middleware#2322. This is handled there by webpack/webpack-dev-middleware#2351. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Add
disconectonEventSourceWrapperfor making close eventSource manually possible.Breaking Changes
Additional Info