chore: Correct stats generation in webpack 5#452
Open
sergiocarracedo wants to merge 1 commit into
Open
Conversation
The committers listed above are authorized under a signed CLA. |
Member
|
Can you accept CLA? |
sergiocarracedo
force-pushed
the
chore/correct-stats-generation-webpack-5
branch
from
August 8, 2024 20:30
2eb9ed5 to
8934430
Compare
bjohansebas
added a commit
to webpack/webpack-dev-middleware
that referenced
this pull request
Jul 20, 2026
webpack-dev-server does not send module names over the wire: the HMR runtime logs module ids on apply. Align the SSE payload with that (name, action, time, hash, errors, warnings) instead of serializing a module id → name map that was only used for log cosmetics and was empty with the default stats options anyway. Ref webpack/webpack-hot-middleware#452 Ref webpack/webpack-hot-middleware#306
Member
|
webpack-hot-middleware is being migrated into webpack-dev-middleware — see webpack/webpack-dev-middleware#2322. This is handled there by webpack/webpack-dev-middleware#2349. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
The stats generation via
buildModuleMapusesmodule.idwhich doesn't exist in webpack 5 returning just the last module (as the key of the map is alwaysundefined)Breaking Changes
NONE: Still prioritizing module.id, if it is not defined fallback the value to index or identifier
Additional Info