Make sure the passed email is the email_to - #3286
Merged
DaleMcGrew merged 1 commit intoSep 12, 2026
Merged
DaleMcGrew merged 1 commit into
DaleMcGrew merged 1 commit into
Conversation
Member
|
Thank you @mjacquot1! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Regardless of the valid email passed into the form it will send the reset email to the primary account email.
Solution: Pull the value from the form and make sure that it is passed into the
send_mail()functionTesting:
Testing is tricky because of how much of it is using django abstracted auth classes. I can confirm through debugpy that this function is called. when the send reset email is sent. I'm fairly confident that it is pull the email value form the form. But this will need to be verified in Prod.