Skip to content

[WV-4556] WeConnect: Add the ability to delete a profile--Support person disappears from the interface [TEAM REVIEW] #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaleMcGrew merged 2 commits into from
Jun 24, 2026
Merged

[WV-4556] WeConnect: Add the ability to delete a profile--Support person disappears from the interface [TEAM REVIEW] #190

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1aeeb3c
person disappears from the interface as soon as the API response come…
pravingv Jun 16, 2026
eb7bf45
lint fixes
pravingv Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions src/js/react-query/mutations.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,17 +187,30 @@ const usePersonSaveMutation = () => {

const usePersonDeleteMutation = () => {
const queryClient = useQueryClient();
const { setAppContextValue } = useConnectAppContext();
const { setAppContextValue, apiDataCache } = useConnectAppContext();
const dispatch = useConnectDispatch();

return useMutation({
mutationFn: (params) => weConnectQueryFn('person-delete', params, METHOD.GET),
onError: (error) => console.log('error in usePersonDeleteMutation: ', error),
onSuccess: (results) => {
// console.log('usePersonDeleteMutation onSuccess, results:', results);
onSuccess: (results, variables) => {
const { allPeopleCache } = apiDataCache;
const deletedId = results?.personId || variables?.personId || variables?.id;

// console.log('usePersonDeleteMutation onSuccess, deletedId:', deletedId, ', results:', results);
if (results.success === true) {
// Invalidate person list to refresh the list after deletion
queryClient.invalidateQueries({ queryKey: ['person-list-retrieve']});
queryClient.invalidateQueries({ queryKey: ['team-list-retrieve']});
// Remove the deleted person from allPeopleCache
const allPeopleCacheNew = { ...allPeopleCache };
delete allPeopleCacheNew[deletedId];
dispatch({ type: 'updateByKeyValue', key: 'allPeopleCache', value: allPeopleCacheNew });

// Completely erase the list memory BEFORE triggering a refetch to stop stale data syncs
queryClient.removeQueries({ queryKey: ['person-list-retrieve']});
queryClient.removeQueries({ queryKey: ['team-list-retrieve']});

// Trigger a fresh background fetch for safety
queryClient.refetchQueries({ queryKey: ['person-list-retrieve']}).catch((error) => console.error('userPersonDeletMutation person-list-retrieve refetch failed:', error));
queryClient.refetchQueries({ queryKey: ['team-list-retrieve']}).catch((error) => console.error('userPersonDeletMutation team-list-retrieve refetch failed:', error));
// Close the profile drawer
setAppContextValue('headerProfileDrawerOpen', false);
setAppContextValue('profileDrawerPerson', undefined);
Expand Down Expand Up @@ -296,4 +309,3 @@ export {
useProfileChangeLogRetrieveMutation,
useDeleteTaskMutation,
};

Loading