fix: make routineId nullable to prevent crash on free workout logs#1257
Open
mmustafasenoglu wants to merge 2 commits into
Open
fix: make routineId nullable to prevent crash on free workout logs#1257mmustafasenoglu wants to merge 2 commits into
mmustafasenoglu wants to merge 2 commits into
Conversation
Server allows workout logs without a routine (free/ad-hoc logging), but the app's Drift table declared routineId as non-nullable. This caused a null check operator crash when PowerSync delivered a row with routine_id = NULL. Changes: - WorkoutLogTable.routineId: integer() → integer().nullable() - Log.routineId: late int → int? - Log constructor: required this.routineId → this.routineId - Log.toCompanion: handle null routineId with Value.absent() Fixes wger-project#1250
Member
|
thanks for the PR @mmustafasenoglu ! it seems you need to commit the changed generated files |
Author
|
Hi @rolandgeider, thanks for the review! The generated files have been committed now — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
routineIdnullable inWorkoutLogTableandLogmodel to fix a crash when workout logs have no associated routine.Problem
The server allows workout logs without a routine (free/ad-hoc logging):
routine = ForeignKey('Routine', ..., null=True). However, the app's Drift table declaredroutineIdas non-nullable, causing:in
WorkoutLogTableTable.mapwhen PowerSync delivers a row withroutine_id = NULL.Changes
WorkoutLogTable.routineId:integer()→integer().nullable()Log.routineId:late int→int?Logconstructor:required this.routineId→this.routineIdLog.toCompanion: handle null routineId withValue.absent()Testing
Verified that the app no longer crashes when opening a routine that has workout logs without an associated routine.
Fixes #1250