WFLY-20443 Develop a quickstart which demonstrated the dynamic SSL Cotext capability#1161
WFLY-20443 Develop a quickstart which demonstrated the dynamic SSL Cotext capability#1161fRandOmizer wants to merge 1 commit into
Conversation
|
@skyllarr , please. take a look. |
skyllarr
left a comment
skyllarr
left a comment
There was a problem hiding this comment.
Hi @fRandOmizer , I just added some initial minor comments, I will try to run this quickstart once these are fixed to make sure it works.
| # Script to configure dynamic SSL context in the JBoss EAP server | ||
|
|
||
| # Create the server's keystores | ||
| /subsystem=elytron/key-store=twoWayKS1:add(path=server1.keystore.P12,relative-to=jboss.server.config.dir,credential-reference={clear-text=secret},type=JKS) |
There was a problem hiding this comment.
Let's not use JKS anywhere, it's becoming obsolete, we should use PKCS12
| . Make sure {productName} server is started. | ||
| . Open a terminal and navigate to the root directory of this quickstart. | ||
| ifdef::reactive-messaging[] | ||
| . Run this command to enable the MicroProfile Reactive Messaging functionality on the server |
There was a problem hiding this comment.
Let's not forget to remove this readme
| @@ -0,0 +1,16 @@ | |||
| <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd"> | |||
| @@ -0,0 +1,147 @@ | |||
| /* | |||
| * Copyright 2023 JBoss by Red Hat. | |||
There was a problem hiding this comment.
this is old version of header
| private static final String SERVER_HOST_FIRST_PORT = "https://localhost:9443"; | ||
| private static final String SERVER_HOST_SECOND_PORT = "https://localhost:10443"; | ||
| private static final String ARTIFACT_ID = "/helloworld-dynamic-ssl-context/"; | ||
| private static final String DEFAULT_SERVER_DIR = System.getProperty("user.dir") + "/target/server"; |
There was a problem hiding this comment.
Can it be JBOSS_HOME? We often use it
|
|
||
| == What is it? | ||
|
|
||
| The `helloworld-dynamic-ssl-context` quickstart demonstrates enabled dynamic ssl context for specified URLs and their ports. The only function they represents is to be called via provided REST client and pass as successful call through the SSL/TLS configuration. |
There was a problem hiding this comment.
I would mention somewhere here that elytron client also supports dynamic ssl context and that it can be configured anywhere in the subsystem where ssl-context attribute can be configured. SO it is not just with the REST client
| include::../shared-doc/system-requirements.adoc[leveloffset=+1] | ||
| // Use of {jbossHomeName} | ||
| include::../shared-doc/use-of-jboss-home-name.adoc[leveloffset=+1] | ||
|
|
There was a problem hiding this comment.
we can mention how to run them here to be consistent with the rest of quickstarts
| [[review_the_modified_server_configuration]] | ||
| == Review the Modified Server Configuration | ||
|
|
||
| There are too many additions to the configuration file to list here. Feel free to compare the `standalone.xml` to the backup copy to see the changes made to configure the server to run this quickstart. |
There was a problem hiding this comment.
I am lazy to check, but is this sentence consistent with some other quickstarts?
| Send request to port 10443 | ||
| ---- | ||
|
|
||
| Each of links executes https GET request on server under specified ports, which has enabled dynamic SSL context. |
There was a problem hiding this comment.
I would mention that it is the same ssl context configured
2 participants
WFLY-20443 Develop a quickstart which demonstrated the dynamic SSLContext capability