Skip to content

chore: rename Ciphersuite -> CipherSuite [WPB-25044]#2109

Merged
coriolinus merged 7 commits intomainfrom
prgn/chore/25044-ciphersuite-capitalization
May 8, 2026
Merged

chore: rename Ciphersuite -> CipherSuite [WPB-25044]#2109
coriolinus merged 7 commits intomainfrom
prgn/chore/25044-ciphersuite-capitalization

Conversation

@coriolinus
Copy link
Copy Markdown
Contributor

What's new in this PR


PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@coriolinus coriolinus requested a review from a team May 6, 2026 07:59
Comment thread crypto-ffi/src/ciphersuite.rs Outdated
Comment thread crypto-ffi/src/core_crypto_context/mls.rs Outdated
Comment thread crypto-ffi/src/ciphersuite.rs Outdated
Copy link
Copy Markdown
Member

@SimonThormeyer SimonThormeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if CryptoCiphersuite and MlsCiphersuite are both openmls types, if they're not, we should also rename those.

@coriolinus coriolinus force-pushed the prgn/chore/25044-ciphersuite-capitalization branch from c20d289 to 6ad3631 Compare May 6, 2026 11:18
@coriolinus coriolinus force-pushed the prgn/chore/25044-ciphersuite-capitalization branch from 89bcc51 to 05d17a6 Compare May 8, 2026 11:49
@coriolinus coriolinus force-pushed the prgn/chore/25044-ciphersuite-capitalization branch from 9daad36 to 10fba21 Compare May 8, 2026 15:41
@coriolinus coriolinus merged commit 10fba21 into main May 8, 2026
35 checks passed
@coriolinus coriolinus deleted the prgn/chore/25044-ciphersuite-capitalization branch May 8, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants