refactor: simplify path finding impl#5
Open
coriolinus wants to merge 4 commits intowire/stablefrom
Open
Conversation
The existing implementation was mainly written 4 years ago, and used idioms even older than that. Rust has come a long way since then! This is a purely mechanical refactoring accomplished by repeatedly scanning for old patterns and replacing them with something more modern. But all substitutions preserved 100% semantic equivalence. No serious attempt has been made to actually understand the code. On the other hand, the code should be much easier to understand now.
The existing implementation was mainly written 4 years ago, and used idioms even older than that. Rust has come a long way since then! This is a purely mechanical refactoring accomplished by repeatedly scanning for old patterns and replacing them with something more modern. But all substitutions preserved 100% semantic equivalence. No serious attempt has been made to actually understand the code. On the other hand, the code should be easier to understand now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
SQPIT-764References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.