Skip to content

fix: Apps shown as disabled in group conversation details (WPB-25306)#4804

Open
alexandreferris wants to merge 1 commit intodevelopfrom
fix/apps_shown_disabled_in_group_conversation_options
Open

fix: Apps shown as disabled in group conversation details (WPB-25306)#4804
alexandreferris wants to merge 1 commit intodevelopfrom
fix/apps_shown_disabled_in_group_conversation_options

Conversation

@alexandreferris
Copy link
Copy Markdown
Member

@alexandreferris alexandreferris commented May 8, 2026

https://wearezeta.atlassian.net/browse/WPB-25306

  • Remove extra verification for AppsAllowedResult when only isServicesAllowed is necessary
  • adjust existing test

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When:

  • web created a group with apps enabled by default (even with apps feature flag disabled)
  • web showed enabed
  • android showed disabled but should have shown enabled

Causes (Optional)

The verification was checking for both conversation.isServicesAllowed and AppsAllowedResult (expecting it to be enabled) but showed disabled

Solutions

Remove unnecessary check for AppsAllowedResult when only conversation.isServiceAllowed was enough.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  • have a conversation with Apps enabled (MLS conversation + MLS team + Apps feature flag enabled)
  • disable Apps feature flag
    then:

v4.25 / v4.26:

  • Check conversation details, will show Apps value as OFF / Disabled

this PR:

  • Check conversation details, will show Apps value as ON / Enabled (but still not clickable)

- Remove extra verification for AppsAllowedResult when only isServicesAllowed is necessary
- adjust existing test

Signed-off-by: alexandreferris <ferris.alexandre@gmail.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 8, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.12%. Comparing base (b13b597) to head (8e6a877).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4804      +/-   ##
===========================================
- Coverage    51.13%   51.12%   -0.01%     
===========================================
  Files          610      610              
  Lines        21089    21086       -3     
  Branches      3399     3398       -1     
===========================================
- Hits         10783    10780       -3     
  Misses        9291     9291              
  Partials      1015     1015              
Files with missing lines Coverage Δ
...tions/details/GroupConversationDetailsViewModel.kt 88.97% <100.00%> (-0.24%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b13b597...8e6a877. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants