fix: Apps shown as disabled in group conversation details (WPB-25306)#4804
Open
alexandreferris wants to merge 1 commit intodevelopfrom
Open
fix: Apps shown as disabled in group conversation details (WPB-25306)#4804alexandreferris wants to merge 1 commit intodevelopfrom
alexandreferris wants to merge 1 commit intodevelopfrom
Conversation
- Remove extra verification for AppsAllowedResult when only isServicesAllowed is necessary - adjust existing test Signed-off-by: alexandreferris <ferris.alexandre@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4804 +/- ##
===========================================
- Coverage 51.13% 51.12% -0.01%
===========================================
Files 610 610
Lines 21089 21086 -3
Branches 3399 3398 -1
===========================================
- Hits 10783 10780 -3
Misses 9291 9291
Partials 1015 1015
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



https://wearezeta.atlassian.net/browse/WPB-25306
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When:
Causes (Optional)
The verification was checking for both
conversation.isServicesAllowedandAppsAllowedResult(expecting it to be enabled) but showed disabledSolutions
Remove unnecessary check for
AppsAllowedResultwhen onlyconversation.isServiceAllowedwas enough.Testing
Test Coverage (Optional)
How to Test
then:
v4.25 / v4.26:
this PR: