-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Add esp8266_2m_min: minimal ESP02 build for OTA recovery #5577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+23
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It really is stupid AI day -- this comment is just plain incorrect. Flashing a smaller program binary (serial or otherwise) will not allow you to OTA the "full" build later -- it's the partition map that matters. The full build is still too big (even compressed) to fit in the available OTA space with
ldscript_2m512k.We have essentially two options:
2m256kor2m128kare both long term safe -- the uncompressed program binary is capped at 1MB, so with compression it should always fit in 768k. Of course, by repartitioning, existing devices would need to be reconfigured from scratch.Likely we want to do both...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@willmmiles I would have thought so too but users report this to work for some reason:
https://www.reddit.com/r/WLED/comments/1t625n2/comment/okhfmch/?utm_source=share&utm_medium=web3x&utm_name=web3xcss&utm_term=1&utm_content=share_button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for version 17, if we are still going to support such limited hardware as the ESP02, then i think we just need to accept it will be two-step upgrade for users, possibly with a minimal image for stage 1 that is even more stripped back / optimised for this use.
This is preferable I would say to just pulling more and more features as the core of WLED grows in size