Skip to content

Migrate NewDomainsSearchRepository from FluxC to wordpress-rs#22891

Merged
oguzkocer merged 2 commits into
trunkfrom
integrate-wordpress-rs-domains
May 26, 2026
Merged

Migrate NewDomainsSearchRepository from FluxC to wordpress-rs#22891
oguzkocer merged 2 commits into
trunkfrom
integrate-wordpress-rs-domains

Conversation

@oguzkocer
Copy link
Copy Markdown
Contributor

@oguzkocer oguzkocer commented May 25, 2026

Description

Replace FluxC's ProductsStore + dispatcher-based domain suggestions with direct wordpress-rs API calls:

  • Fetch domain suggestions via WpComApiClient.domains().suggestions()
  • Fetch products via WpComApiClient.products().list() for sale pricing
  • Match suggestions to products by productId to get server-formatted combinedSaleCostDisplay (1:1 with trunk's behavior)
  • Remove SuggestedDomainsFetcher (FluxC dispatcher wrapper)

Testing instructions

  • Compare the Me > Domains > Find a domain flow before and after this change.

Here are 2 recordings to showcase it:
before.webm
after.webm

@oguzkocer oguzkocer added this to the 26.8 milestone May 25, 2026
@dangermattic
Copy link
Copy Markdown
Collaborator

dangermattic commented May 25, 2026

1 Warning
⚠️ This PR is assigned to the milestone 26.8. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented May 25, 2026

App Icon📲 You can test the changes from this Pull Request in WordPress Android by scanning the QR code below to install the corresponding build.

App NameWordPress Android
Build TypeDebug
Versionpr22891-0f2f69f
Build Number1488
Application IDorg.wordpress.android.prealpha
Commit0f2f69f
Installation URL0v7340p9c60io
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Copy Markdown
Contributor

wpmobilebot commented May 25, 2026

App Icon📲 You can test the changes from this Pull Request in Jetpack Android by scanning the QR code below to install the corresponding build.

App NameJetpack Android
Build TypeDebug
Versionpr22891-0f2f69f
Build Number1488
Application IDcom.jetpack.android.prealpha
Commit0f2f69f
Installation URL0v5mce22ht310
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Copy Markdown
Contributor

🤖 Build Failure Analysis

This build has failures. Claude has analyzed them - check the build annotations for details.

Comment on lines +39 to +40
onlyWordpressdotcom = false, // checkstyle ignore
includeWordpressdotcom = false, // checkstyle ignore
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkmassel Would you prefer if we changed these parameter field names to comply with our checkstyle rules, or keep them as is — matching what the API returns?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes a lot more sense to match the API

@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2026

Codecov Report

❌ Patch coverage is 95.12195% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.32%. Comparing base (14a65bc) to head (0f2f69f).
⚠️ Report is 1 commits behind head on trunk.

Files with missing lines Patch % Lines
...earch/domainsfetcher/NewDomainsSearchRepository.kt 95.12% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #22891   +/-   ##
=======================================
  Coverage   37.32%   37.32%           
=======================================
  Files        2320     2319    -1     
  Lines      124580   124585    +5     
  Branches    16926    16928    +2     
=======================================
+ Hits        46498    46506    +8     
+ Misses      74321    74318    -3     
  Partials     3761     3761           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@oguzkocer oguzkocer marked this pull request as ready for review May 25, 2026 05:53
@oguzkocer oguzkocer requested review from a team and nbradbury and removed request for a team May 25, 2026 22:30
Copy link
Copy Markdown
Contributor

@nbradbury nbradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :shipit:

oguzkocer added 2 commits May 26, 2026 13:29
Replace FluxC's `ProductsStore` + dispatcher-based domain suggestions
with direct wordpress-rs API calls:

- Fetch domain suggestions via `WpComApiClient.domains().suggestions()`
- Fetch products via `WpComApiClient.products().list()` for sale pricing
- Match suggestions to products by `productId` to get server-formatted
  `combinedSaleCostDisplay` (1:1 with trunk's behavior)
- Remove `SuggestedDomainsFetcher` (FluxC dispatcher wrapper)
@oguzkocer oguzkocer force-pushed the integrate-wordpress-rs-domains branch from 0b11406 to 0f2f69f Compare May 26, 2026 17:29
@oguzkocer oguzkocer enabled auto-merge (squash) May 26, 2026 17:41
@oguzkocer oguzkocer merged commit 941ac5b into trunk May 26, 2026
21 of 22 checks passed
@oguzkocer oguzkocer deleted the integrate-wordpress-rs-domains branch May 26, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants