Skip to content

feat(core): add board event observer - #1163

Merged
pubuzhixing8 merged 2 commits into
developfrom
xingxing/add-board-event-observer
Aug 6, 2026
Merged

feat(core): add board event observer#1163
pubuzhixing8 merged 2 commits into
developfrom
xingxing/add-board-event-observer

Conversation

@pubuzhixing8

@pubuzhixing8 pubuzhixing8 commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add a framework-independent createBoardEventObserver() testing helper
  • record selected downstream board events while preserving the original handlers
  • expose call clearing and document the required plugin ordering
  • export the helper from core testing and add a patch changeset
  • add a Chinese usage example covering plugin ordering, assertions, and cleanup

Why

Drawnix plugin tests need to verify that a plugin delegates an event downstream, not only that no board state changed. Keeping the observer in core makes that assertion reusable without coupling it to Jasmine, Vitest, or Jest.

Validation

  • built @plait/core successfully with Angular package build
  • ran the core TypeScript check successfully
  • verified formatting with Prettier
  • Docgeni compiled all documentation content successfully; the subsequent Angular site subprocess was terminated by SIGABRT in the local environment

No fixture-specific tests were added, per the requested scope.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 2, 2026

Copy link
Copy Markdown

Deploying plait with  Cloudflare Pages  Cloudflare Pages

Latest commit: c36bc23
Status: ✅  Deploy successful!
Preview URL: https://9ae1d4c9.plait.pages.dev
Branch Preview URL: https://xingxing-add-board-event-obs.plait.pages.dev

View logs

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 2, 2026

Copy link
Copy Markdown

Deploying plait-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: c36bc23
Status: ✅  Deploy successful!
Preview URL: https://e34c251c.plait-docs.pages.dev
Branch Preview URL: https://xingxing-add-board-event-obs.plait-docs.pages.dev

View logs

@pubuzhixing8
pubuzhixing8 marked this pull request as ready for review August 2, 2026 13:41
@pubuzhixing8

Copy link
Copy Markdown
Collaborator Author

Help me review @nightt5879

@nightt5879 nightt5879 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The plugin ordering and downstream event delegation look correct, and the documentation is clear.

@pubuzhixing8
pubuzhixing8 merged commit e3da344 into develop Aug 6, 2026
3 checks passed
@pubuzhixing8
pubuzhixing8 deleted the xingxing/add-board-event-observer branch August 6, 2026 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants