Skip to content

Return Cow instead of String from chunkid#51

Open
Shatur wants to merge 1 commit into
wowemulation-dev:mainfrom
Shatur:cow-chunkid
Open

Return Cow instead of String from chunkid#51
Shatur wants to merge 1 commit into
wowemulation-dev:mainfrom
Shatur:cow-chunkid

Conversation

@Shatur
Copy link
Copy Markdown

@Shatur Shatur commented May 15, 2026

Pull Request

Summary

Avoid allocations if possible in chunkid.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test improvements
  • Build system/dependency changes

Related Issues

Closes #47.

Fixes #(issue number)

Testing

cargo test passes.

Tested On

  • Linux
  • macOS
  • Windows

Quality Checklist

  • Code follows project style guidelines
  • Self-review of code completed
  • Tests pass locally
  • Documentation updated (if applicable)

By submitting this PR, I confirm that:

Avoid allocations if possible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: return Cow instead of String from chunkid

1 participant