Skip to content

Added a fix for the lightbox #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CrochetFeve0251 wants to merge 6 commits into
base: develop
Choose a base branch
from
+198 −1
Open

Added a fix for the lightbox #762

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d218e9c
Added a fix for the lightbox by not passing the wp attributes to the …
CrochetFeve0251 Nov 22, 2023
e0bad90
Merge branch 'develop' into bug/758-fix-lightbox
remyperona Jan 5, 2026
2515e56
fix CS
remyperona Jan 5, 2026
d018206
Merge branch 'develop' into bug/758-fix-lightbox
nicomollet Jan 8, 2026
b3b7d66
Merge remote-tracking branch 'origin/develop' into bug/758-fix-lightbox
Honemo Jul 13, 2026
4ea5bf0
Add unit tests for data-wp attribute filtering in build_picture_tag()
Honemo Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion classes/Webp/Picture/Display.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,11 @@ protected function build_picture_tag( $image ) {
unset( $attributes['data-object-position'] );
}

$output = '<picture' . $this->build_attributes( $attributes ) . ">\n";
$picture_attributes = array_filter( $attributes, function ( $attribute ) {
return strpos( $attribute, 'data-wp' ) === false;
}, ARRAY_FILTER_USE_KEY );

$output = '<picture' . $this->build_attributes( $picture_attributes ) . ">\n";
/**
* Allow to add more <source> tags to the <picture> tag.
*
Expand Down