[cmd3, epilogue] Automatically log the v3 scheduler#8785
[cmd3, epilogue] Automatically log the v3 scheduler#8785SamCarlberg wants to merge 2 commits intowpilibsuite:2027from
Conversation
Epilogue logging is set up to capture fields and methods, which means that the scheduler would have to be logged by assigning it to a field or to a public Scheduler-returning method in a logged class.
This adds special handling to detect the v3 scheduler on the classpath and automatically log it under `${root}/Command Scheduler` so users don't need to manually log it
|
Why wouldn’t we just include |
I figured it's easier to have the library handle it by default so people don't need to think about it. We could include something similar in the v3 templates, too. I'd just be concerned about teams removing it (or cargo culting from other teams who removed it) and wondering why they're not getting scheduler telemetry. |
|
I don't see cargo culting as a counterargument here, as teams can just as easily cargo-cult the disable code. I mainly don't like it being quite so aggressively automatic when we have dedicated templates for command projects. |
|
Yeah, I think it's better to just have a Telemetry call in the template rather than special case it. Sure, some people might remove it via cargo culting, but most won't. It's also a little weird to have this one single exception in the library. |
Epilogue logging is set up to capture fields and methods, which means that the scheduler would have to be logged by assigning it to a field or to a public Scheduler-returning method in a logged class.
This adds special handling to detect the v3 scheduler on the classpath and automatically log it under
${root}/Command Schedulerso users don't need to manually do so.Users can opt out by turning off the corresponding configuration option: