Skip to content

Add python exclusions to gitignore#710

Closed
daltzctr wants to merge 2 commits intowpilibsuite:mainfrom
daltzctr:patch-1
Closed

Add python exclusions to gitignore#710
daltzctr wants to merge 2 commits intowpilibsuite:mainfrom
daltzctr:patch-1

Conversation

@daltzctr
Copy link
Copy Markdown

No description provided.

Comment thread vscode-wpilib/resources/gradle/shared/.gitignore Outdated
@ThadHouse
Copy link
Copy Markdown
Member

There are too many raw file blocks in here. Do all of these file types get put in the root?

@daltzctr
Copy link
Copy Markdown
Author

It's mostly pulled from the github python template gitignore. The only ones I've noticed locally are __pycache__ and venv

@ThadHouse
Copy link
Copy Markdown
Member

Yeah we'd want to limit this to folders. Raw blocking file types is incorrect, because other projects might need those.

@daltzctr
Copy link
Copy Markdown
Author

@ThadHouse I've minimized to just what I think is necessary for Python

@sciencewhiz
Copy link
Copy Markdown
Contributor

Under what conditions would these python files end up in a gradle wpi project?

@daltzctr
Copy link
Copy Markdown
Author

It doesn't currently but all robotpy init does is add a robot.py and pyproject.toml, but given #622 I would expect VS Code to create Python projects.

Additionally, robotpy init doesn't have a gitignore either, which requires users to create their own. Using the wpilib project gitignore seems like a good start.

@sciencewhiz
Copy link
Copy Markdown
Contributor

I think that robotpy init making a .gitignore would be better then copying a C++/Java .gitignore. And even if it was implemented in the vs-code extension, I think it would be a different .gitignore, rather then adding onto the C++/Java one.

@sciencewhiz
Copy link
Copy Markdown
Contributor

robotpy now creates a .gitignore. robotpy/robotpy-installer#128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants