-
Notifications
You must be signed in to change notification settings - Fork 447
[6.0] Update compatible Java versions for deployment #6319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
|
|
||
| The following sections provide high-level information on the recommended deployment pattern. | ||
|
|
||
|
|
||
|
Check failure on line 5 in en/identity-server/6.0.0/docs/deploy/deployment-guide.md
|
||
| ## Introduction | ||
|
|
||
| You can run multiple nodes of WSO2 Identity Server in a cluster mode to achieve two requirements. | ||
|
|
@@ -71,7 +71,8 @@ | |
| </tr> | ||
| <tr class="even"> | ||
| <th>Java</th> | ||
| <td>Oracle JDK 1.8</td> | ||
| <td><p>For information on tested JDKs, see <a href="{{base_path}}/deploy/environment-compatibility/#tested-operating-systems-and-jdks">Tested Operating Systems and JDKs</a> | ||
|
Check warning on line 74 in en/identity-server/6.0.0/docs/deploy/deployment-guide.md
|
||
| .</p></td> | ||
| </tr> | ||
| <tr class="odd"> | ||
| <th>Web browsers</th> | ||
|
|
@@ -137,7 +138,7 @@ | |
|
|
||
| 3. **Governance Repository**: This stores configuration and data that are shared across the whole platform. This typically includes services, service descriptions, endpoints, or data sources. | ||
|
|
||
|
|
||
|
Check failure on line 141 in en/identity-server/6.0.0/docs/deploy/deployment-guide.md
|
||
| <!--!!! info | ||
| For more information about the registry, | ||
| see [Work with the Registry](TO-DO:{{base_path}}/guides/working-with-the-registry).--> | ||
|
|
@@ -327,7 +328,7 @@ | |
| - `KUBERNETES_API_SERVER_USERNAME`: This is the Kubernetes Master username (optional), e.g., `admin`. | ||
| - `KUBERNETES_API_SERVER_PASSWORD`: This is the Kubernetes Master password (optional). | ||
|
|
||
|
|
||
|
Check failure on line 331 in en/identity-server/6.0.0/docs/deploy/deployment-guide.md
|
||
| 2. Configure caching. | ||
|
|
||
| !!! note | ||
|
|
@@ -458,7 +459,7 @@ | |
| !!! abstract "" | ||
| **Example** | ||
| ``` | ||
| [transport.http.properties] | ||
|
Check failure on line 462 in en/identity-server/6.0.0/docs/deploy/deployment-guide.md
|
||
| proxyPort = 80 | ||
| [transport.https.properties] | ||
| proxyPort = 443 | ||
|
|
@@ -466,7 +467,7 @@ | |
|
|
||
| 4. You may change the `<IS_HOME>/repository/conf/deployment.toml` file to access the servers using a hostname instead of the raw IP. This hostname is how the external applications try to look up WSO2 Identity Server endpoints. The `hostName` should be resolved to the Load Balancer front-end IP address. | ||
|
|
||
| ``` | ||
|
Check failure on line 470 in en/identity-server/6.0.0/docs/deploy/deployment-guide.md
|
||
| [server] | ||
| hostname = "wso2.is" | ||
| ``` | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add
JDKsto the Vale vocabulary.Vale reports
JDKstwice on Line 74.JDKsis the correct plural of the established acronymJDK, so add it to.vale/styles/config/vocabularies/vocab/accept.txtand rerun Vale.As per coding guidelines, resolve all Vale warnings before finalizing documentation.
🧰 Tools
🪛 GitHub Check: Vale style check
[warning] 74-74:
[vale] reported by reviewdog 🐶
Did you really mean 'JDKs'?
Raw Output:
{"message":"Did you really mean 'JDKs'?","location":{"path":"en/identity-server/6.0.0/docs/deploy/deployment-guide.md","range":{"start":{"line":74,"column":165},"end":{"line":74,"column":169}}},"severity":"WARNING","code":{"value":"Vale.Spelling"}}
[warning] 74-74:
[vale] reported by reviewdog 🐶
Did you really mean 'JDKs'?
Raw Output:
{"message":"Did you really mean 'JDKs'?","location":{"path":"en/identity-server/6.0.0/docs/deploy/deployment-guide.md","range":{"start":{"line":74,"column":34},"end":{"line":74,"column":38}}},"severity":"WARNING","code":{"value":"Vale.Spelling"}}
🤖 Prompt for AI Agents
Sources: Coding guidelines, Linters/SAST tools