Make mempool fee API URL configurable#2069
Open
Bortlesboat wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This keeps the mempool widget defaulting to mempool.space, but lets users set an alternate compatible fee endpoint with
apiURL.I work on Satoshi API, so the concrete use case I tested this against is a mempool-compatible hosted fee endpoint:
https://bitcoinsapi.com/api/v1/compat/mempool/fees/recommendedThe change is intentionally generic: no default changes, no new dependency, and self-hosted mempool.space-compatible URLs work the same way.
Verification:
go test ./modules/cryptocurrency/mempoolnot run locally becausego/gofmtare not installed in this Windows environment.git diff --checkpassed.