[codex] Add experimental FSDP meta-parameter support - #2
Closed
wujingyue wants to merge 1 commit into
Closed
Conversation
wujingyue
force-pushed
the
meta
branch
2 times, most recently
from
June 14, 2026 22:31
7319584 to
1685c91
Compare
wujingyue
force-pushed
the
fsdp/minimal
branch
2 times, most recently
from
June 16, 2026 18:59
9e9c5f0 to
8655b36
Compare
Signed-off-by: Jingyue Wu <wujingyue@gmail.com>
Owner
Author
|
Moved to upstream PR NVIDIA#5369. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intentionally separated from the minimal FSDP cleanup in the current stacked branch so the meta-parameter support can be kept, revised, or dropped independently.
What changed:
fully_shardhandling for direct meta parameters by materializing withto_empty(...)and invokingreset_parameters()/_reset_parameters()before ParameterGroup construction.Validation:
CUDA_VISIBLE_DEVICES= uv run --no-sync python -m torch.distributed.run --nproc-per-node 8 -m pytest -q tests/unit_tests/distributed/megatron_fsdp/test_experimental_fully_shard.py(8 passed, 1 skipped)Notes:
uv run ...command could not run in this session becauseuvattempted to modify/opt/venvand hit a permission error.