fix(router): skip plan cache OnEvict during graphMux shutdown#3009
fix(router): skip plan cache OnEvict during graphMux shutdown#3009arutkowski00 wants to merge 1 commit into
Conversation
Ristretto Close() clears all plan cache entries and fires OnEvict for each one, migrating them into slowplancache right before both caches are torn down. Disable OnEvict during intentional mux shutdown and wait for pending slow-cache writes first.
|
Warning Review limit reached
More reviews will be available in 23 minutes and 58 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dkorittki
left a comment
dkorittki
left a comment
There was a problem hiding this comment.
Looks good to me generally. It does not make sense to call the OnEvict hook to migrate lots of slow plan caches to the fallback cache when the new graph server is already created (and thus has created its plancache from oldplancache already). It's unnecessary work. I just added one comment which should be handled before I can approve.
| if s.planFallbackCache != nil { | ||
| s.planFallbackCache.Wait() | ||
| } |
There was a problem hiding this comment.
Actually I don't think we need to wait for pending writes to the cache at this point because we are about to delete the cache anyways.
|
Closing this PR because this is now handled in #3023 |
2 participants
Problem
planCache.Close()invokesOnEvictfor every entry, migrating them intoslowplancacheimmediately before both caches are torn down during mux shutdown.Fix
Disable
OnEvictduring intentional mux shutdown and wait for pending slow-cache writes before closing plan caches.Test plan
go test ./router/core/...Part of config hot-reload memory leak investigation (monday.com #3221).