chore: propose @openfed__queryCache rfc#3039
Conversation
WalkthroughThis PR adds a new RFC markdown document proposing an ChangesRFC: queryCache directive
Estimated code review effort: 1 (Trivial) | ~5 minutes Related Issues: None specified. Related PRs: None specified. Suggested labels: rfc, documentation Suggested reviewers: None specified. 🐰 A whisker twitch, a cache key spun, 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@rfc/openfed__queryCache-v1.md`:
- Around line 84-94: Clarify the query-cache contract in the RFC so it matches
the composer’s existing type-aware normalization: update the
`@openfed__queryCache` section to explicitly state whether `QueryCache` is
allowed on any query return type or only on entity-backed fields, and align that
with `entityCacheConfigByTypeName` and future entity-cache validation
expectations. If the intent is still type agnostic, say so and note that entity
type tracking in the composer is reserved for other directives; if not, revise
the wording and errors section to require entity-backed returns.
- Around line 8-19: The RFC for `@openfed__queryCache` introduces includeHeaders
and shadowMode without defining their behavior. Update the directive spec in
openfed__queryCache-v1 to explicitly state which request headers are part of the
cache key when includeHeaders is enabled, and define exactly what shadowMode
does versus normal caching. Use the directive name and its option fields
includeHeaders and shadowMode to keep the wording unambiguous and
implementation-ready.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: f05b0154-9840-4a57-a4e2-19db4c320790
📒 Files selected for processing (1)
rfc/openfed__queryCache-v1.md
Summary by CodeRabbit
New Features
Bug Fixes
Checklist
Open Source AI Manifesto
This project follows the principles of the Open Source AI Manifesto. Please ensure your contribution aligns with its principles.