Skip to content

feat(router): disallow inline argument values (ENG-9586)#3044

Closed
gausie wants to merge 21 commits into
mainfrom
worktree-playful-rolling-lecun
Closed

feat(router): disallow inline argument values (ENG-9586)#3044
gausie wants to merge 21 commits into
mainfrom
worktree-playful-rolling-lecun

refactor(router): simplify disallow inline arguments after review

b283df6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 4, 2026 in 0s

61.60% (target 30.00%)

View this Pull Request on Codecov

61.60% (target 30.00%)

Details

Codecov Report

❌ Patch coverage is 84.42907% with 45 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.60%. Comparing base (3ed663b) to head (b283df6).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
router/core/inline_arguments.go 90.22% 11 Missing and 2 partials ⚠️
router/core/errors.go 83.01% 6 Missing and 3 partials ⚠️
router/core/graphql_handler.go 60.86% 6 Missing and 3 partials ⚠️
router/core/operation_processor.go 70.96% 6 Missing and 3 partials ⚠️
router/core/defer_response_writer.go 78.57% 2 Missing and 1 partial ⚠️
router/core/graph_server.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3044      +/-   ##
==========================================
+ Coverage   61.46%   61.60%   +0.14%     
==========================================
  Files         261      262       +1     
  Lines       30596    30792     +196     
==========================================
+ Hits        18805    18970     +165     
- Misses      10277    10301      +24     
- Partials     1514     1521       +7     
Files with missing lines Coverage Δ
router/core/context.go 74.92% <ø> (ø)
router/core/graphql_prehandler.go 85.81% <100.00%> (+0.13%) ⬆️
router/core/websocket.go 78.28% <100.00%> (+0.43%) ⬆️
router/internal/persistedoperation/client.go 91.80% <100.00%> (+0.27%) ⬆️
router/pkg/config/config.go 82.29% <ø> (ø)
router/pkg/otel/attributes.go 62.50% <ø> (ø)
router/core/graph_server.go 85.30% <75.00%> (-0.09%) ⬇️
router/core/defer_response_writer.go 71.18% <78.57%> (-0.25%) ⬇️
router/core/errors.go 78.60% <83.01%> (-1.58%) ⬇️
router/core/graphql_handler.go 62.32% <60.86%> (+0.40%) ⬆️
... and 2 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.