Failing regression test for APQ TTL renewal corrupting stored query#3061
Open
benevolent-donut wants to merge 1 commit into
Open
Failing regression test for APQ TTL renewal corrupting stored query#3061benevolent-donut wants to merge 1 commit into
benevolent-donut wants to merge 1 commit into
Conversation
Contributor
WalkthroughAdds a new test file for the router core package that verifies Automatic Persisted Query (APQ) TTL renewal does not corrupt the stored query. Includes an in-memory mock KV client and a test simulating registration and hash-only replay requests. ChangesAPQ TTL Renewal Test
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
|
Hi, thanks for the issue and reproduction, we'll take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See title and #3062
Summary by CodeRabbit