Skip to content

Failing regression test for APQ TTL renewal corrupting stored query#3061

Open
benevolent-donut wants to merge 1 commit into
wundergraph:mainfrom
benevolent-donut:apq-ttl-renewal-corruption-test
Open

Failing regression test for APQ TTL renewal corrupting stored query#3061
benevolent-donut wants to merge 1 commit into
wundergraph:mainfrom
benevolent-donut:apq-ttl-renewal-corruption-test

Conversation

@benevolent-donut

@benevolent-donut benevolent-donut commented Jul 8, 2026

Copy link
Copy Markdown

See title and #3062

Summary by CodeRabbit

  • Tests
    • Added a regression test for automatic persisted queries to ensure TTL renewal keeps the stored query intact.
    • Covered both initial registration and hash-only replay flows to verify persisted query data remains unchanged after renewal.

@benevolent-donut benevolent-donut requested a review from a team as a code owner July 8, 2026 21:49
@github-actions github-actions Bot added the router label Jul 8, 2026
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Adds a new test file for the router core package that verifies Automatic Persisted Query (APQ) TTL renewal does not corrupt the stored query. Includes an in-memory mock KV client and a test simulating registration and hash-only replay requests.

Changes

APQ TTL Renewal Test

Layer / File(s) Summary
Mock KV client and TTL renewal test
router/core/operation_processor_apq_ttl_test.go
Adds ttlMockKVClient mock implementing Get/Set/Close, and TestAPQTTLRenewalDoesNotCorruptStoredQuery, which registers a query, replays it via hash-only request to trigger TTL renewal, and asserts the stored KV value still matches the original raw query.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the added regression test for APQ TTL renewal corrupting the stored query.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@endigma

endigma commented Jul 9, 2026

Copy link
Copy Markdown
Member

Hi, thanks for the issue and reproduction, we'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants