fix(router): drain only in-flight requests of muxes the graph server tears down#3064
Conversation
Router-nonroot image scan passed✅ No security vulnerabilities found in image: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
WalkthroughThis change moves in-flight request tracking from the graphServer level to individual graphMux instances, adding a per-mux atomic counter and an ChangesMux-owned in-flight tracking and shutdown wait
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3064 +/- ##
==========================================
+ Coverage 61.85% 61.89% +0.03%
==========================================
Files 261 261
Lines 30649 30657 +8
==========================================
+ Hits 18958 18974 +16
+ Misses 10179 10173 -6
+ Partials 1512 1510 -2
🚀 New features to boost your workflow:
|
0f2d926 to
314d6f4
Compare
Summary by CodeRabbit