-
Notifications
You must be signed in to change notification settings - Fork 92
feat(helm)!: Add the Spider subchart and compression-coordinator wiring for Spider-orchestrated compression. #2418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
20001020ycx
merged 34 commits into
y-scope:main
from
20001020ycx:feat/2026-07-21-spider-storage-subchart
Aug 4, 2026
Merged
Changes from 14 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
adc1af8
feat(helm): Add the Spider subchart (storage-only) and compression-co…
20001020ycx a812975
refine comment
20001020ycx be6e09e
refactor(helm): Gate Spider orchestration on `spider.enabled` alone.
20001020ycx dabc0ab
refactor(helm): Give `compression_coordinator` populated defaults and…
20001020ycx a48ead3
comments
20001020ycx 764e7e0
refactor(helm): Add `clp.spiderStoragePort` helper.
20001020ycx 755fc11
refactor(helm): Fix the Spider subchart's resource names via `fullnam…
20001020ycx 8512e84
refactor(helm): Drop redundant comment.
20001020ycx 7feb0fe
refactor(helm): Align the compression-coordinator Deployment with the…
20001020ycx ff23f0a
Merge branch 'main' into feat/2026-07-21-spider-storage-subchart
junhaoliao 8eb92a4
fix(helm): Align the compression-coordinator config with the coordina…
20001020ycx 104a68d
feat(helm): Pin the Spider subchart to upstream release 0.1.4 and com…
20001020ycx f26ff14
refactor(helm): Inline the `clp.spiderOrchestrationEnabled` helper as…
20001020ycx f4f2b83
ci(lint): Register the Spider chart repo for `ct lint` dependency bui…
20001020ycx 8a3c7e7
chore(helm): Bump the chart version to 0.4.1-dev.3 (main took 0.4.1-d…
20001020ycx 309cefa
Merge remote-tracking branch 'origin/main' into feat/2026-07-21-spide…
20001020ycx 7dfe382
fix(helm): Use `helm dependency update` in set-up scripts so fresh ma…
20001020ycx 390f2ff
fix(helm): Use `helm dependency update` in the package task so the pu…
20001020ycx 637a46c
feat(helm): Bump the Spider subchart to 0.1.5 (task-executor logs now…
20001020ycx c201a47
feat(helm): Default the Spider worker image to the CLP-published `clp…
20001020ycx a8659c7
feat(helm): Bake the Spider worker's CLP wiring into the chart's defa…
20001020ycx 34f7f9b
refactor(helm): Move `fullnameOverride` under `global` so the Spider …
20001020ycx 4e91080
refactor(helm): Move naming overrides under `global` and derive the S…
20001020ycx fb55eb8
fix on comment
20001020ycx 2a8ca89
Merge remote-tracking branch 'origin/main' into feat/2026-07-21-spide…
20001020ycx aef4cb9
chore(helm): Bump the chart version to 0.4.1-dev.4 (post-main-merge).
20001020ycx 4d9b2da
feat(helm): Default the Spider worker's `service_account_name` to CLP…
20001020ycx e975b25
refactor(helm): Drop the redundant comment on `service_account_name`.
20001020ycx 7d50905
feat(helm): Bump the Spider subchart to 0.1.8 (worker `serviceAccount…
20001020ycx 834d8d6
feat(helm): Deploy the Celery compression scheduler and worker regard…
20001020ycx 5cd94f1
Merge branch 'main' into feat/2026-07-21-spider-storage-subchart
20001020ycx c2af1ec
Apply suggestions from code review
20001020ycx 1fb0b98
Update tools/deployment/package-helm/templates/_helpers.tpl
20001020ycx 85edf6e
Merge branch 'main' into feat/2026-07-21-spider-storage-subchart
junhaoliao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # Subcharts are downloaded by `helm dependency update`. | ||
| charts/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| dependencies: | ||
| - name: spider | ||
| repository: https://github.com/y-scope/spider/raw/gh-pages | ||
| version: 0.1.4 | ||
| digest: sha256:ef717c497d7d93913e52811b5128da41be08bdfa9dc2e586f2b7e2528eea0791 | ||
| generated: "2026-07-27T13:33:18.893480848-04:00" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 changes: 75 additions & 0 deletions
75
tools/deployment/package-helm/templates/compression-coordinator-deployment.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| {{- if .Values.spider.enabled }} | ||
| apiVersion: "apps/v1" | ||
| kind: "Deployment" | ||
| metadata: | ||
| name: {{ include "clp.fullname" . }}-compression-coordinator | ||
| labels: | ||
| {{- include "clp.labels" . | nindent 4 }} | ||
| app.kubernetes.io/component: "compression-coordinator" | ||
| spec: | ||
| replicas: 1 | ||
| selector: | ||
| matchLabels: | ||
| {{- include "clp.selectorLabels" . | nindent 6 }} | ||
| app.kubernetes.io/component: "compression-coordinator" | ||
| template: | ||
| metadata: | ||
| labels: | ||
| {{- include "clp.labels" . | nindent 8 }} | ||
| app.kubernetes.io/component: "compression-coordinator" | ||
| spec: | ||
| {{- include "clp.createSchedulingConfigs" (dict | ||
| "root" . | ||
| "component" "compressionCoordinator" | ||
| ) | nindent 6 }} | ||
| serviceAccountName: {{ include "clp.fullname" . }}-service-account | ||
| terminationGracePeriodSeconds: 60 | ||
| initContainers: | ||
| - {{- include "clp.waitFor" (dict | ||
| "root" . | ||
| "type" "job" | ||
| "name" "db-table-creator" | ||
| ) | nindent 10 }} | ||
| - {{- include "clp.waitFor" (dict | ||
| "root" . | ||
| "type" "service" | ||
| "name" "storage" | ||
| ) | nindent 10 }} | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| containers: | ||
| - name: "compression-coordinator" | ||
| image: {{ include "clp.imageRef" (dict "root" . "component" "clpPackage") | quote }} | ||
| imagePullPolicy: "{{ .Values.image.clpPackage.pullPolicy }}" | ||
| env: | ||
| {{- include "clp.telemetryEnv" . | nindent 12 }} | ||
| - name: "CLP_DB_PASS" | ||
| valueFrom: | ||
| secretKeyRef: | ||
| name: {{ include "clp.fullname" . }}-database | ||
| key: "password" | ||
| - name: "CLP_DB_USER" | ||
| valueFrom: | ||
| secretKeyRef: | ||
| name: {{ include "clp.fullname" . }}-database | ||
| key: "username" | ||
| - name: "OTEL_SERVICE_NAME" | ||
| value: "compression-coordinator" | ||
| - name: "RUST_LOG" | ||
| value: {{ .Values.clpConfig.compression_coordinator.logging_level | quote }} | ||
| {{- include "clp.createResourceLimits" (dict | ||
| "root" . | ||
| "component" "compressionCoordinator" | ||
| ) | nindent 10 }} | ||
| volumeMounts: | ||
| - name: "config" | ||
| mountPath: "/etc/clp-config.yaml" | ||
| subPath: "clp-config.yaml" | ||
| readOnly: true | ||
| command: [ | ||
| "/opt/clp/bin/compression-coordinator", | ||
| "--config", "/etc/clp-config.yaml" | ||
| ] | ||
| volumes: | ||
| - name: "config" | ||
| configMap: | ||
| name: {{ include "clp.fullname" . }}-config | ||
| {{- end }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.