-
Notifications
You must be signed in to change notification settings - Fork 92
feat(compression-coordinator): Complete S3 compression job handle implementation. #2420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
LinZhihao-723
merged 12 commits into
y-scope:main
from
Bill-hbrhbr:compression-coordinator-job-handle-impl
Jul 29, 2026
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b07a473
impl
Bill-hbrhbr 47d677b
Merge branch 'main' into compression-coordinator-job-handle-impl
junhaoliao 0ef11ac
Include dispatch_time column.
LinZhihao-723 8a6be0a
Revert "Include dispatch_time column."
LinZhihao-723 1a2a2ec
Review and polish .
LinZhihao-723 107d3cb
Review the rest.
LinZhihao-723 75f236c
Symbol reordering.
LinZhihao-723 72e8c5a
Merge oss-main.
LinZhihao-723 abf8912
Fix logging.
LinZhihao-723 93aee60
Remove redundant compression_jobs schema setup from initialize-orches…
LinZhihao-723 b2cee3a
Revert database config.
LinZhihao-723 8ca1e9a
Remove empty line.
LinZhihao-723 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,9 @@ | ||
| use serde::Deserialize; | ||
|
|
||
| use crate::clp_config::{AwsAuthentication, S3Config}; | ||
| use crate::{ | ||
| clp_config::{AwsAuthentication, S3Config}, | ||
| dataset::resolve_dataset_name, | ||
| }; | ||
|
|
||
| /// Mirror of `clp_py_utils.clp_config.ClpConfig`. | ||
| /// | ||
|
|
@@ -89,14 +92,54 @@ pub struct Database { | |
| pub host: String, | ||
| pub port: u16, | ||
| pub names: ClpDbNames, | ||
|
|
||
| #[serde(skip)] | ||
| pub table_prefix: String, | ||
| } | ||
|
|
||
| impl Database { | ||
| /// # Returns | ||
| /// | ||
| /// The archives table name `<prefix><dataset>_archives`, where a `None` dataset resolves to | ||
| /// `default`. | ||
| #[must_use] | ||
| pub fn archives_table_name(&self, dataset: Option<&str>) -> String { | ||
| self.archive_metadata_table_name("archives", dataset) | ||
| } | ||
|
|
||
| /// # Returns | ||
| /// | ||
| /// The column-metadata table name `<prefix><dataset>_column_metadata`, where a `None` dataset | ||
| /// resolves to `default`. | ||
| #[must_use] | ||
| pub fn column_metadata_table_name(&self, dataset: Option<&str>) -> String { | ||
| self.archive_metadata_table_name("column_metadata", dataset) | ||
| } | ||
|
|
||
| /// Builds a per-dataset archive-metadata table name. | ||
| /// | ||
| /// # Returns | ||
| /// | ||
| /// `<prefix><dataset>_<suffix>`, where `dataset` defaults to the `CLP_S` default. | ||
| fn archive_metadata_table_name(&self, suffix: &str, dataset: Option<&str>) -> String { | ||
| format!( | ||
| "{}{}_{suffix}", | ||
| self.table_prefix, | ||
| resolve_dataset_name(dataset) | ||
| ) | ||
| } | ||
| } | ||
|
LinZhihao-723 marked this conversation as resolved.
|
||
|
|
||
| impl Default for Database { | ||
| fn default() -> Self { | ||
| /// Mirror of `clp_py_utils.clp_config.CLP_METADATA_TABLE_PREFIX`. | ||
| const CLP_METADATA_TABLE_PREFIX: &str = "clp_"; | ||
|
|
||
| Self { | ||
| host: "localhost".to_owned(), | ||
| port: 3306, | ||
| names: ClpDbNames::default(), | ||
| table_prefix: CLP_METADATA_TABLE_PREFIX.to_owned(), | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is in #2406. |
||
| } | ||
| } | ||
| } | ||
|
|
||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is in #2406. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've splitted this to #2421.