-
Notifications
You must be signed in to change notification settings - Fork 92
feat(compression-coordinator): Introduce max_concurrent_tasks config to limit job-handler concurrency.
#2435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Bill-hbrhbr
wants to merge
23
commits into
y-scope:main
Choose a base branch
from
Bill-hbrhbr:coordinator/limit-job-submission-concurrency
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+233
−148
Open
Changes from 20 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
739dd2a
First implementation
Bill-hbrhbr 51ede0e
Merge branch 'main' into coordinator/limit-job-submission-concurrency
Bill-hbrhbr fb1a960
Merge branch 'main' into coordinator/limit-job-submission-concurrency
Bill-hbrhbr 4830f76
Merge branch 'main' into coordinator/limit-job-submission-concurrency
Bill-hbrhbr 2d83f7b
Pass max concurrency limit through clp config. Complete clp config te…
Bill-hbrhbr 95074ce
revise docstring and rename variables
Bill-hbrhbr 2fb4d8a
Fix syntax and docstrings
Bill-hbrhbr e083517
Minor improvements
Bill-hbrhbr a256362
Add invalid config error for exceeding sem max
Bill-hbrhbr ccebe54
Clarify that the concurrency limit may be exceeded with extended time…
Bill-hbrhbr 46e219c
Update config wording
Bill-hbrhbr 46c47f9
Merge branch 'main' into coordinator/limit-job-submission-concurrency
Bill-hbrhbr c6ea927
Merge branch 'main' into coordinator/limit-job-submission-concurrency
LinZhihao-723 a75016f
First implementation
Bill-hbrhbr 191d127
Remove the config for docker compose as it is not ready yet
Bill-hbrhbr 0986378
Address review comment by using bounded fetch
Bill-hbrhbr eee03da
recover not only running jobs but also dispatched jobs
Bill-hbrhbr 96de148
Always take a limit argument for fetch_new_job_rows
Bill-hbrhbr 283018f
Improve docstring
Bill-hbrhbr e044371
Fix docstrings and make create_job_handle return Some instead of Resu…
Bill-hbrhbr 1bcf75a
Change max_concurrent_tasks to max_concurrent_jobs
Bill-hbrhbr 6aa5533
Add job handler dispatch time update
Bill-hbrhbr dad216c
Merge branch 'coordinator/ensure-running-job-with-dispatch-time' into…
Bill-hbrhbr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.