refactor(clp-package)!: Remove legacy Spider build and runtime code. - #2460
refactor(clp-package)!: Remove legacy Spider build and runtime code.#2460sitaowang1998 wants to merge 3 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
WalkthroughThe legacy Spider compression orchestration, worker launcher, dependencies, build tasks, container image integration, and related documentation were removed. ChangesLegacy Spider removal
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Worth dropping it here too, along with its row in the |
Description
Closes #2440.
This PR removes the remaining legacy build, packaging and Python runtime code. The legacy Docker Compose deployment and configuration were already removed in #2452, leaving these components unreachable but still built and shipped.
The followings are removed:
spider_schedulerandspider_workerpackage binaries.mariadb-connector-cppbuild dependency.libmariadbcpp.sofrom the CLP package image.yscope-spider-pyPython dependency and its transitive lockfile entries.This also removes the Ubuntu-only restriction imposed by the legacy Spider build.
Checklist
breaking change.
Validation performed
Summary by CodeRabbit
Removed Features
Chores
Documentation