Skip to content

fix(compression-coordinator): Ensure running Spider jobs always have a dispatch_time. #2462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bill-hbrhbr merged 4 commits into from
Aug 11, 2026
+10 −2
Merged

fix(compression-coordinator): Ensure running Spider jobs always have a dispatch_time. #2462

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6aa5533
Add job handler dispatch time update
Bill-hbrhbr Aug 8, 2026
c3f6f16
Merge branch 'main' into coordinator/ensure-running-job-with-dispatch…
Bill-hbrhbr Aug 8, 2026
1df15e1
Update components/compression-coordinator/src/coordination.rs
Bill-hbrhbr Aug 9, 2026
b3d802d
Merge branch 'main' into coordinator/ensure-running-job-with-dispatch…
LinZhihao-723 Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion components/compression-coordinator/src/coordination.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,9 @@ impl Coordinator {

/// Marks the compression jobs identified by `job_ids` with the current dispatch time.
///
/// If the `dispatch_time` has already been set by the `job_handler`, we preserve the value and
/// skip the update. See [`S3CompressionJobHandle::persist_spider_job_id`] for details.
///
Comment thread
Bill-hbrhbr marked this conversation as resolved.
Outdated
/// # Errors
///
/// Returns an error if:
Expand All @@ -305,7 +308,8 @@ impl Coordinator {
let mut tx = self.db_pool.begin().await?;
for chunk in job_ids.chunks(1000) {
let mut query_builder = sqlx::QueryBuilder::<sqlx::MySql>::new(formatcp!(
"UPDATE `{table}` SET `dispatch_time` = CURRENT_TIMESTAMP() WHERE `id` IN (",
"UPDATE `{table}` SET `dispatch_time` = COALESCE(`dispatch_time`, \
CURRENT_TIMESTAMP()) WHERE `id` IN (",
table = COMPRESSION_JOB_TABLE_NAME,
));
let mut separated_ids = query_builder.separated(", ");
Expand Down
9 changes: 8 additions & 1 deletion components/compression-coordinator/src/job_handle.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,12 @@ impl<SubmitterType: S3CompressionJobSubmitter> S3CompressionJobHandle<SubmitterT
/// This method associates the given Spider job ID with the compression job in the CLP database
/// and updates the compression job status to [`CompressionJobStatus::Running`].
///
/// This method also ensures that the job has a valid `dispatch_time`, which the coordinator
/// uses to mark jobs as dispatched. A coordinator restart may occur before the marker is
/// persisted, leaving the Spider job running without a valid `dispatch_time`. Therefore, this
/// method sets the field as part of row update if it has not already been set by the
/// coordinator.
///
/// # Errors
///
/// Returns an error if:
Expand All @@ -455,7 +461,8 @@ impl<SubmitterType: S3CompressionJobSubmitter> S3CompressionJobHandle<SubmitterT
i32::try_from(num_tasks).map_err(|_| Error::TooManyCompressionTasks(num_tasks))?;
sqlx::query(formatcp!(
"UPDATE `{COMPRESSION_JOB_TABLE_NAME}` SET `spider_id` = ?, `status` = ?, `num_tasks` \
= ?, `start_time` = CURRENT_TIMESTAMP(3) WHERE `id` = ?"
= ?, `start_time` = CURRENT_TIMESTAMP(3), `dispatch_time` = \
COALESCE(`dispatch_time`, CURRENT_TIMESTAMP()) WHERE `id` = ?"
))
.bind(spider_job_id.get())
.bind(CompressionJobStatus::Running)
Expand Down
Loading