Skip to content

fix: add BSD tar fallback support for macOS #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackluo923 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add BSD tar fallback support for macOS #102

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2644990
fix: add BSD tar fallback support for macOS
jackluo923 Jan 20, 2026
40c913f
style: fix yamllint line length violation
jackluo923 Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 25 additions & 11 deletions exports/taskfiles/utils/remote.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,21 +103,35 @@ tasks:
mkdir -p "{{.OUTPUT_DIR}}"
# Unlike for `tar --create`, in `--extract` both the exclude and include patterns can be
# quoted since they're both evaluated by `tar`.
- >-
{{.ARCHIVER}}
--extract
--strip-components="{{.NUM_COMPONENTS_TO_STRIP}}"
--directory "{{.OUTPUT_DIR}}"
--file "{{.TAR_FILE}}"
--no-anchored
--wildcards
- |-
ARCHIVER="{{.ARCHIVER}}"
# Fall back to 'tar' if the specified archiver doesn't exist (e.g., gtar on macOS)
USE_GNU_FLAGS=true
if ! command -v "$ARCHIVER" &> /dev/null; then
ARCHIVER="tar"
USE_GNU_FLAGS=false
fi

# Build tar command with conditional GNU-specific flags
TAR_CMD=("$ARCHIVER" --extract --strip-components="{{.NUM_COMPONENTS_TO_STRIP}}" --directory "{{.OUTPUT_DIR}}" --file "{{.TAR_FILE}}")
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated

# Add GNU-specific flags only if using gtar
if [ "$USE_GNU_FLAGS" = true ]; then
TAR_CMD+=(--no-anchored --wildcards)
fi

# Add exclude patterns
{{- range .EXCLUDE_PATTERNS}}
--exclude="{{.}}"
TAR_CMD+=(--exclude="{{.}}")
{{- end}}

# Add include patterns
{{- range .INCLUDE_PATTERNS}}
"{{.}}"
TAR_CMD+=("{{.}}")
{{- end}}
2> /dev/null

# Execute tar command
"${TAR_CMD[@]}" 2> /dev/null
Comment on lines +139 to +140

@coderabbitai coderabbitai Bot Jan 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Consider whether suppressing all stderr is desirable.

Redirecting 2> /dev/null hides all tar errors, which could mask legitimate issues (e.g., corrupted archives, permission problems). If this is intentional to suppress noisy warnings, a comment explaining the rationale would help future maintainers.

🤖 Prompt for AI Agents 
In `@exports/taskfiles/utils/remote.yaml` around lines 139 - 140, The tar
invocation currently silences all stderr via the redirection on the
"${TAR_CMD[@]}" invocation, which can hide real errors; update the call to
either remove the "2> /dev/null" so tar errors surface or redirect stderr to a
log file/variable instead, and if suppression is intentionally desired add a
clarifying comment explaining why warnings are ignored; reference the TAR_CMD
invocation ("${TAR_CMD[@]}") and ensure the change preserves the intended
behavior for noisy but non-fatal warnings or surfaces fatal errors for
debugging.

# This command must be last
- task: "checksum:compute"
vars:
Expand Down
Loading