Skip to content

Fix broken test output when skipped test passes #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
willcosgrove wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix broken test output when skipped test passes #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion lib/quickdraw/basic_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,19 @@ def refute(value, ...)
# Indicate that an assertion passed successfully.
def success!
if @skip
@runner.failure!("The skipped test `#{@description}` started passing.")
test_location = @block.source_location
locations = caller_locations
location = locations.find { |it| it.path.end_with?(".test.rb") } || locations.first

@runner.failure!({
"class_name" => self.class.name,
"test_path" => test_location[0],
"test_line" => test_location[1],
"description" => @description,
"message" => "The skipped test `#{@description}` started passing. Remove `skip: true` to re-enable it.",
"path" => location.path,
"line" => location.lineno,
})
else
@runner.success!(@description)
end
Expand Down
Loading