Add ignore_slots support to Patroni DCS configuration#3021
Open
PavelZaytsev wants to merge 7 commits into
Open
Add ignore_slots support to Patroni DCS configuration#3021PavelZaytsev wants to merge 7 commits into
PavelZaytsev wants to merge 7 commits into
Conversation
- Add ignore_slots field to Patroni struct in CRD
- Add ignore_slots to patroniDCS struct for Spilo configuration
- Generate ignore_slots in SPILO_CONFIGURATION when specified
- Update CRD manifest to accept ignore_slots field
- Add unit test for ignore_slots configuration
This enables PostgreSQL 17 native slot synchronization support by allowing
users to configure Patroni to ignore specific replication slot types (e.g.,
logical slots) during failover operations.
Users can now configure ignore_slots in their PostgreSQL manifest:
patroni:
ignore_slots:
- type: logical
This instructs Patroni to ignore logical replication slots during failover,
which is essential for PostgreSQL 17's native logical slot synchronization
feature where slots are automatically synced to standbys.
PavelZaytsev
requested review from
FxKu,
Jan-M,
hughcapet,
idanovinda,
jopadi,
mikkeloscar and
sdudoladov
as code owners
|
Cannot start a pipeline due to: Click on pipeline status check Details link below for more information. |
|
Cannot start a pipeline due to: Click on pipeline status check Details link below for more information. |
Author
|
Hi @mikkeloscar could someone from the maintainers team look into this PR when they get the chance/run CI/CD? |
|
Cannot start a pipeline due to: Click on pipeline status check Details link below for more information. |
|
Cannot start a pipeline due to: Click on pipeline status check Details link below for more information. |
Author
|
@FxKu @hughcapet @mikkeloscar can someone from the zalando team run the check-in pipeline on the PR plz |
|
Cannot start a pipeline due to: Click on pipeline status check Details link below for more information. |
|
Every cluster switchover leads to Debezium full initial snapshot. |
|
@FxKu @hughcapet |
Member
|
LGTM. Only a mention in the docs is missing. |
|
@PavelZaytsev hi! could you, please, update this PR with documentation? |
|
While building own version of operator, I applied patches on top of Now cluster successfully patched, but no changes was made to StatefulSet: In STS variable Maybe there are some changes on When I create new cluster with |
|
Second missing piece of puzzle - sync code. I can't see how I can add commits to this PR.. |
Member
|
@baznikin The PostgresCRDResourceValidation does not exist anymore in the latest main branch. But you're right about the missing sync code. @PavelZaytsev can you add this missing piece and cover the option in the docs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PostgreSQL 17 introduced native logical replication slot synchronization, where logical slots are synced to standby servers. However, if both enabled, Patroni's logical slot failover inteferes resulting in a faulty behavior. This PR adds support for Patroni's
ignore_slotsDCS configuration to allow operators to exclude specific slot types (e.g., logical slots) from failover blocking.Implementation
This enables PostgreSQL 17 (and user-defined) slot synchronization support by allowing users to configure Patroni to ignore specific replication slot types (e.g., logical slots) during failover operations.
Users can now configure ignore_slots in their PostgreSQL manifest:
This instructs Patroni to ignore logical replication slots during failover.
Testing
k8sres_test.gofor ignore_slots configurationpatronictl show-config)