Use local LSP binary if available#43
Merged
Merged
Conversation
MrSubidubi
approved these changes
Jun 9, 2026
MrSubidubi
left a comment
Contributor
There was a problem hiding this comment.
This change was not tested as I am unsure how to do that and the change seems straightforward
You can use install dev extension and could have checked out the path used.
That said, it indeed is just that, so happy to merge. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20
I was annoyed by Zed downloading a bunch of things and this extension was one of the culprits 🙂
Following the pattern in the other file, this enables the local binary to be used if available (say if the user installed it with
brew install dockerfile-language-serverornpm install -g dockerfile-language-server-nodejs). If not, the LSP is downloaded as before.This change was not tested as I am unsure how to do that and the change seems straightforward 😅 I am happy to test it if y'all want me to!