Allow extension to work while offline#71
Merged
Conversation
Keep the relative path to the latest version to fall back on when fetching the GitHub release fails. Ideally we could even optimistically use that while updating in the background, or something, but that's not implemented in this commit.
|
We require contributors to sign our Contributor License Agreement, and we don't have @emilio on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Contributor
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
MrSubidubi
approved these changes
Jun 10, 2026
MrSubidubi
left a comment
Contributor
There was a problem hiding this comment.
While we really should look for a more general fix for this issue on the Zed side, I think this is a sensible fix in the meantime to deal with this issue.
Thanks and congrats to your first contribution! 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the relative path to the latest version to fall back on when fetching the GitHub release fails.
Ideally we could even optimistically use that while updating in the background, or something, but that's not implemented in this commit.