fix: stop dropping request bodies for composed schemas in codegen - #39
Merged
Conversation
The resource and MCP generators only read body params from the schema's top-level properties, so composed request bodies generated methods with no body at all: create_ad_audience() could never send its required fields and always 400'd, and create_messaging_ad / create_call_ad / create_ctwa_ad were equally broken. $ref and allOf bodies now flatten into normal kwargs; oneOf/anyOf unions fall back to a required raw body dict sent verbatim. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resource and MCP generators only read body params from the schema's top-level properties, so composed request bodies generated methods with no body at all:
create_ad_audience()could never send its required fields and always 400'd, andcreate_messaging_ad/create_call_ad/create_ctwa_adwere equally broken.$refandallOfbodies now flatten into normal kwargs;oneOf/anyOfunions fall back to a required raw body dict sent verbatim.