Add known language codes - #39
Open
florabtw wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
The test failure seems unrelated. It might be that the raw data from google is inconsistent =/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to get rid of google-translate-tts now that this repo has been updated to work with new API, and these language codes are one of the differences that I liked.
But no hard feelings if you don't want the codes in this library, I'll just continue to maintain it separately in google-tts-languages.
Also, happy to change the interface. I'm not good at TS, and I would have preferred
googleTTS.languagesas the array itself (with the lookup functions bound to it), but I couldn't figure out the correct TS types to make it happen.To clarify: Not all language codes in the Google TTS documentation are actually supported by the unofficial Google Translate API, which is why the list I have added is not the same as the docs. I've been maintaining my own list for the sake of https://soundoftext.com and the only reason I know to add new ones is because I get emailed from users.