Remove unnecessary COMMAND_ACK#3705
Open
av-remco wants to merge 1 commit into
Open
Conversation
…ontroller should send COMMAND_ACK
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Removes an extra GCS-side acknowledgment during mission upload so MissionPlanner doesn’t send a redundant COMMAND_ACK after the flight controller already acknowledged the operation.
Changes:
- Removed
port.setWPACK(sysid, compid, type);calls from the mission upload and partial mission update flows. - Leaves mission upload completion reliant on the FC’s
COMMAND_ACKonly (no GCS echo-ack).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
148
to
153
| } | ||
| } | ||
|
|
||
| port.setWPACK(sysid, compid, type); | ||
|
|
||
| } | ||
| catch (Exception ex) | ||
| { |
Contributor
Author
There was a problem hiding this comment.
A comment is unnecessary. Someone in the future should consult the mavlink mission protocol
Contributor
Author
|
@meee1 Any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a mission upload operation the flight controller confirms the upload with a COMMAND_ACK. MissionPlanner then replies with another unnecessary COMMAND_ACK. This PR removes it.
Does not cause any regression, since the GCS should never send COMMAND_ACK with type = 0 during mission upload