Fix HttpClient misuse: reuse static instance, remove duplicate headers, add missing error handling#3715
Open
ArthurPatriot wants to merge 1 commit into
Open
Fix HttpClient misuse: reuse static instance, remove duplicate headers, add missing error handling#3715ArthurPatriot wants to merge 1 commit into
ArthurPatriot wants to merge 1 commit into
Conversation
ArthurPatriot
force-pushed
the
fix/http-reuse
branch
2 times, most recently
from
c4583df to
4634d72
Compare
ArthurPatriot
force-pushed
the
fix/http-reuse
branch
from
4634d72 to
af311aa
Compare
ArthurPatriot
changed the title
Contributor
Author
|
@meee1 when you have a time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HttpClient was being instantiated on every request across Download, Tracking, and adsb. This is a well-known anti-pattern that exhausts the system's socket pool under load (each disposed instance holds a socket in TIME_WAIT for up to 4 minutes).