Preserve relative-alt guided behavior by setting Locationwp.frame at implicit callers#3728
Open
Copilot wants to merge 2 commits into
Open
Preserve relative-alt guided behavior by setting Locationwp.frame at implicit callers#3728Copilot wants to merge 2 commits into
Locationwp.frame at implicit callers#3728Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix ripple effect for setGuidedModeWP callers
Preserve relative-alt guided behavior by setting May 29, 2026
Locationwp.frame at implicit callers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent guided-mode path change surfaced a behavior shift: callers constructing
Locationwpwithoutframenow send defaultGLOBAL(AMSL) instead of the previously normalized relative-alt behavior. For Copter paths passing relative altitude, this can produce unintended altitude commands.Scope: explicit frame assignment at affected guided callers
frame = (byte)MAVLink.MAV_FRAME.GLOBAL_RELATIVE_ALTwhereLocationwpwas built withlat/lng/altonly beforesetGuidedModeWP(...).Controls/FollowMe.csUtilities/httpserver.cs(/guideGET + POST handlers)Swarm/FollowPath.csExtLibs/ExtGuided/ExtGuidedPlugin.csPlugins/example14-mass.csExtLibs/Xamarin/Xamarin/Linked/httpserver.cs(mirrored HTTP guided handlers)Behavioral intent