wget: retrieve HTTPS URLs through Kandelo networking - #20
Conversation
|
Independent devil's-advocate review completed at tap head Finding fixed:
Review disposition:
Known boundary: The PR remains intentionally unmerged. The main PR gates in the description are still open, and trusted bottle CI must additionally prove |
7fb78db to
e941040
Compare
Exact-head update after tap #70This branch is now based directly on tap main
Through Kandelo's dev shell, the combined eight-formula syntax/style pass is clean, the merged support suite passes 29/216, and branch diff checks pass. A fresh exact-head devil review is still required. This supersedes the older restack head/base/hash paragraph in the PR body. Source materialization remains gated on Automattic/kandelo#882; no bottle, sidecar, receipt, provenance, or poured-install claim is made by this update. |
|
Follow-up to the #70 restack: current exact head is The shared-validator call now rejects only path-map sources that differ from their stable guest destinations. This avoids falsely rejecting Linux-builder opt/ |
|
Independent devil review: ACCEPT at corrected exact head The source/destination assertions now mirror the shared validator: every intended guest identity is required, while a source path is rejected only when it differs. This accepts canonical trusted-Linux The review also independently verified official source/license, OpenSSL and zlib target dependencies, feature exclusions, SDK-vs-package cache ownership, and install completeness. The release Fresh exact-head syntax/load, Homebrew style, 29 support tests / 216 assertions, diff check, source-only scope, formula hash, PR metadata, clean worktree, and exact merge tree pass. Accepted for source merge once Automattic/kandelo#882 lands. Dependency bottles and stock-guest pours remain separate publication gates; no bottle claim is made. |
1430452 to
216e059
Compare
|
Exact-head devil review: ACCEPT for source merge after #882 at |
|
Independent devil's-advocate review: APPROVE this source-only PR at exact head The review found no blocker: the formula builds official Wget 1.25.0 through the ABI 18 SDK, declares its actual tap OpenSSL and zlib target dependencies, keeps native tools scoped to validation, final-relinks before fork instrumentation, and validates ABI/fork/Asyncify/path integrity. Its tests exercise HTTPS+gzip, connection refusal, and a real background fork descendant with loopback I/O, bounded cleanup, byte-exact output, and log assertions. The worktree is clean; formula/source hashes, Ruby syntax, and This approves source merge only. Bottle publication still requires exact merged-head build/pour evidence and Homebrew dependency receipts/provenance. |
216e059 to
b197892
Compare
|
Independent history-only restack review: APPROVE exact head b197892. Formula blob and SHA-256 remain byte-identical; the README delta is only the Wget row; exact syntax, diff, and style checks pass. This is restack approval only: fresh exact source, Node, and Chromium acceptance is still required, with #874/#882 as source gates and dependency-first #888/#890 publication gates preserved. |
b197892 to
7e99e35
Compare
|
Independent exact-head devil's-advocate review: ACCEPT at The reviewer independently reran literal Merge remains intentionally held while Automattic/kandelo#874 and #882 are open. Bottle publication also remains gated on the consolidated ABI outcome owned by the PR #871 worktree. |
7e99e35 to
406bb59
Compare
Purpose
Add GNU Wget 1.25.0 as a first-class Kandelo Homebrew Formula. The Formula builds through Kandelo's normal SDK and sysroot path, links against the tap's OpenSSL and zlib libraries, and exercises real HTTPS, compression, connection-refusal, and background-process behavior.
What this Formula does
wgetexecutable so--backgroundfollows Kandelo's normal process model.wgetrc, Info manual, andwget(1)manual page.nghttp2.org.127.0.0.1:1.The background test intentionally does not start a host Ruby TCP server. Kandelo guest loopback is not host loopback, so using a host listener would test the wrong network topology.
Rebase and source evidence
Current base:
ac0a8f6986bb378fd230563da53ad4cb61cd640bPrepared head:
406bb59fad373048512231697d9204d6f0ccda24Formula/wget.rbis byte-identical before and after the history-only rebase:b706d02f91714fe72a477ee797de6ddf861ebcc41a1cf3a0e2ba6c74b7177dc47bc1fbd7d95ae739b127c25556884f245ac6c79bThe only conflict was the README Formula inventory. Its resolution keeps current
mainand adds the Wget entry after GNU Tar. The final PR diff remains one new Formula and one README line.These exact Formula bytes previously produced a source-built
bin/wgetwith SHA-256 beginningc089b19dand a Homebrew receipt recordingbuilt_as_bottle=falseandpoured_from_bottle=false. The final Formula test then passed and proved HTTPS gzip decoding, successful background-child completion, a positive parent-reported PID, byte-exact output, a completed log, and the expected connection-refusal failure.That earlier runtime result is historical source evidence, not evidence for a current-ABI bottle. The official Wget source archive was rechecked against the Formula's complete SHA-256,
766e48423e79359ea31e41db9e5c289675947a7fcf2efdcedb726ac9d0da3784.Current static validation through Kandelo's canonical dev shell:
brew style Formula/wget.rb: 1 file inspected, no offenses.git diff --check origin/main...HEAD: pass.Independent devil's-advocate review accepted the exact prepared head with no blocking Formula or source-merge finding. A Wget source build and runtime test were not rerun for this history-only rebase; those are required from the exact merged source during current-ABI bottle production.
Merge and publication gates
This source-only Formula has passed rebased exact-head static review. The old ABI 18, #871, and #882 gates no longer apply.
Producing the final bottle is a later, dependency-first step. It waits for:
This PR contains no bottle block, sidecar, archive, receipt, provenance metadata, Wasm binary, Kandelo platform change, or ABI change.