This repository was archived by the owner on Jul 21, 2026. It is now read-only.
test support: await fork descendants in formula runs - #73
Merged
Conversation
Member
Author
|
Devil's-advocate review: ACCEPT at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Let Formula tests prove detached fork behavior without destroying the Kandelo host as soon as the original parent exits. This support is required for durable GNU Wget
--backgroundcoverage and is intentionally split from the Wget Formula PR.Root cause
kandelo_run_wasmpreviously waited only for the root process. A correctly detached parent can return success while its fork child is still downloading or writing output; the runner then destroysNodeKernelHost, so sleeps or post-run file checks cannot distinguish a real completed child from premature teardown.Change
expected_fork_descendants:to the tap Formula helper, with a nonnegative-integer contract.The name is deliberately fork-specific: Kandelo process events include a parent PID for
fork, whileposix_spawnis a separate lifecycle path. No platform event semantics are inferred or widened here.Validation
Through Kandelo
scripts/dev-shell.shat0f12212:run-network-wasm.ts: passed.git diff --check: passed.A full standalone TypeScript typecheck was not claimed because the runner retains the pre-existing Node
Response(process.stdin)BodyInit typing mismatch. Wget exact runtime behavior remains in PR #20 and is not claimed by this support-only PR.This changes no Formula, bottle, sidecar, publisher, Kandelo main runtime, or ABI.