Improve manifest import error handling and diagnostics#571
Open
cubap wants to merge 1 commit into
Open
Conversation
- Add structured console logging for each import attempt - Include manifestUrl and responseStatus in error objects - Improve error display UI with better layout and truncated URLs - Log server error details for debugging
Contributor
Member
Author
|
This adds some console.logs that are a little messy and debuggy, but is also how we do things right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users reported an "unusual manifest import error" when importing certain IIIF manifests. The error message was opaque and didn't indicate which manifest failed or why.
What This PR Does (Client-Side)
Improves error handling and diagnostics in the manifest import component:
[ManifestImport]prefixed messages for start, success, and failuremanifestUrl,responseStatus, anderrorDetailsfor debuggingRoot Cause (Server-Side)
Investigation revealed the actual import failure originates in TPEN-services, not the frontend. The server's
validatePayload.jsrejects valid IIIF manifests when metadata uses language tags other than"none"(e.g.,"en","fr").Server-side fix tracked in: CenterForDigitalHumanities/TPEN-services#530
Notes
This PR improves the client-side experience (better error visibility and debugging) but does not fix the underlying server-side validation bug. The server fix in TPEN-services#530 will resolve the actual import failures.