Skip to content

Improve manifest import error handling and diagnostics #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cubap wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve manifest import error handling and diagnostics #571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 58 additions & 7 deletions components/manifest-import/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,16 +102,18 @@ class ManifestImport extends HTMLElement {
}

const manifestUrl = manifests[currentIndex]
console.log(`[ManifestImport] Worker starting: ${manifestUrl}`)
try {
const project = await this.#importManifest(manifestUrl)
results[currentIndex] = project
console.log(`[ManifestImport] Success: ${manifestUrl} → ${project.label || 'Project created'}`)
} catch (error) {
console.error(`Failed to import manifest: ${manifestUrl}`, error)
results[currentIndex] = {
error: true,
manifestUrl,
message: error.message || 'Failed to create project'
}
console.error(`[ManifestImport] Failed: ${manifestUrl}`, error)
}
}
}
Expand Down Expand Up @@ -139,13 +141,20 @@ class ManifestImport extends HTMLElement {

if (!response.ok) {
let errorMessage = `HTTP ${response.status}`
let errorDetails = null
try {
const errorData = await response.json()
errorMessage = errorData.message || errorMessage
errorDetails = errorData
} catch {
// Response was not JSON - use HTTP status
}
throw new Error(errorMessage)
console.error(`[ManifestImport] Failed to import ${manifestUrl}: ${errorMessage}`, errorDetails || '')
const error = new Error(errorMessage)
error.manifestUrl = manifestUrl
error.responseStatus = response.status
if (errorDetails) error.errorDetails = errorDetails
throw error
}

return response.json()
Expand Down Expand Up @@ -504,11 +513,43 @@ class ManifestImport extends HTMLElement {
margin-bottom: 10px;
}

.error-main {
display: flex;
align-items: flex-start;
gap: 12px;
}

.error-icon-inline {
color: var(--error-color, #d93025);
font-size: 18px;
flex-shrink: 0;
margin-top: 2px;
}

.error-content {
flex: 1;
min-width: 0;
}

.error-message {
font-weight: 600;
color: var(--error-color, #d93025);
margin-bottom: 6px;
}

.error-url {
font-size: 12px;
word-break: break-all;
color: var(--text-secondary, #666);
margin: 10px 0 0 0;
margin: 0 0 6px 0;
font-family: monospace;
max-height: 3.6em;
overflow: hidden;
}

.error-status {
font-size: 11px;
color: var(--text-muted, #999);
font-family: monospace;
}

Expand Down Expand Up @@ -589,12 +630,22 @@ class ManifestImport extends HTMLElement {
<span class="error-icon">✕</span>
Failed (${failed.length})
</div>
${failed.map(error => `
${failed.map(error => {
const errorMessage = error.message || error.error || 'Unknown error'
const truncatedUrl = (error.manifestUrl || '').length > 120
? (error.manifestUrl || '').slice(0, 117) + '...'
: error.manifestUrl || ''
return `
<div class="error-item">
<strong>${escapeHtml(error.message || '')}</strong>
<div class="error-url">${escapeHtml(error.manifestUrl || '')}</div>
<div class="error-main">
<span class="error-icon-inline">✕</span>
<div class="error-content">
<div class="error-message">${escapeHtml(errorMessage)}</div>
<div class="error-url">${escapeHtml(truncatedUrl)}</div>
</div>
</div>
</div>
`).join('')}
`}).join('')}
</div>
` : ''}

Expand Down
Loading