Refactors Masquerade Violation Observer Component - #1441
Open
chazzyjazzy wants to merge 23 commits into
Open
Conversation
chazzyjazzy
commented
Aug 27, 2026
Comment on lines
+6
to
+13
| RegisterSignal(src, COMSIG_MASQUERADE_VIOLATION, TYPE_PROC_REF(/atom/movable, on_masquerade_violation)) | ||
|
|
||
| /mob/living/Destroy(force) | ||
| storyteller_stats = null | ||
| beastmaster_minions = null | ||
| minion_command_components = null | ||
| QDEL_LAZYLIST(splats) | ||
| UnregisterSignal(src, COMSIG_MASQUERADE_VIOLATION) |
Contributor
Author
There was a problem hiding this comment.
ehh... should probably register this on splat level if 'humans cant breach' as per on_observed_violation.
Contributor
Author
|
i have a plan to turn the lists in SSmasquerade into a datum but im opening for now to see if this is good enough which i have a feeling it might be. |
chazzyjazzy
marked this pull request as ready for review
August 27, 2026 00:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
removes the violation observer component and the proximity monitor and reverses it so that instead of NPCs constantly scanning for masq breaches (and thus updating their aoe refs every step), a masq breacher for loops through every atom/movable searching for violation_observer flag set to TRUE and sends comsig_seen_masquerade_violation to all of them with the breacher as the arg.
basically instead of every npc constantly looking for a masq breach, now only masq breachers walk around with a 'hot zone'.
TODO:
actually use the masquerade violating arg on /obj
Why It's Good For The Game
performance? doesnt seem like i've made a major dent as that for loop is nasty - especially when u consider masq violating face, eyes, body. but that's todo.
Changelog
🆑
refactor: removes violation_observer component and prox monitor, bringing it to /atom/movable
/:cl: