Repository navigation
Demos Visual Tests: replace job-level always() with !cancelled() so cancel-in-progress can stop jobs - #34930
Merged
EugeniyKiyashko merged 1 commit intoAug 26, 2026
Conversation
…ancel-in-progress can stop jobs When a workflow run is canceled (by concurrency cancel-in-progress or manually), GitHub re-evaluates job-level if conditions and lets jobs whose condition still holds keep running. always() holds even after cancellation, so every heavy job survived the cancel: the superseded run kept occupying devextreme-shr2 runners until it drained naturally, while the new run waited in pending for the whole time. !cancelled() behaves identically in normal flows (it overrides the implicit success() gate the same way) but turns false once the run is canceled, so jobs actually stop. Step-level always() (result reporting and artifact upload steps) is intentional and left untouched.
alexslavr
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.