Skip to content

Demos Visual Tests: replace job-level always() with !cancelled() so cancel-in-progress can stop jobs #34930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EugeniyKiyashko merged 1 commit into from
Aug 26, 2026
Merged

Demos Visual Tests: replace job-level always() with !cancelled() so cancel-in-progress can stop jobs #34930

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions .github/workflows/visual-tests-demos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
name: Determine scope for framework tests
needs: [check-should-run, get-changes]
if: |
always() &&
!cancelled() &&
needs.check-should-run.outputs.should-run == 'true' &&
(needs.get-changes.result == 'success' || needs.get-changes.result == 'skipped')
outputs:
Expand All @@ -103,7 +103,7 @@ jobs:
name: Determine jQuery test matrix
needs: [check-should-run, determine-framework-tests-scope]
if: |
always() &&
!cancelled() &&
needs.check-should-run.outputs.should-run == 'true' &&
needs.determine-framework-tests-scope.result == 'success'
outputs:
Expand Down Expand Up @@ -148,7 +148,7 @@ jobs:
name: Build DevExtreme
needs: [check-should-run, determine-framework-tests-scope]
if: |
always() &&
!cancelled() &&
needs.check-should-run.outputs.should-run == 'true' &&
needs.determine-framework-tests-scope.result == 'success'
env:
Expand Down Expand Up @@ -280,7 +280,7 @@ jobs:
timeout-minutes: 30
needs: [check-should-run, determine-framework-tests-scope, build-devextreme]
if: |
always() &&
!cancelled() &&
needs.check-should-run.outputs.should-run == 'true' &&
needs.determine-framework-tests-scope.result == 'success' &&
needs.determine-framework-tests-scope.outputs.framework-tests-scope != 'none' &&
Expand Down Expand Up @@ -352,7 +352,7 @@ jobs:
name: Check TS and lint code base
needs: [check-should-run, determine-framework-tests-scope, build-devextreme]
if: |
always() &&
!cancelled() &&
needs.check-should-run.outputs.should-run == 'true' &&
needs.determine-framework-tests-scope.result == 'success' &&
needs.determine-framework-tests-scope.outputs.framework-tests-scope != 'none' &&
Expand Down Expand Up @@ -495,7 +495,7 @@ jobs:
timeout-minutes: 20
needs: [check-should-run, get-changes, build-devextreme, determine-framework-tests-scope]
if: |
always() &&
!cancelled() &&
needs.check-should-run.outputs.should-run == 'true' &&
needs.determine-framework-tests-scope.result == 'success' &&
needs.determine-framework-tests-scope.outputs.framework-tests-scope == 'changed' &&
Expand Down Expand Up @@ -608,7 +608,7 @@ jobs:
timeout-minutes: 20
needs: [check-should-run, build-devextreme, determine-framework-tests-scope]
if: |
always() &&
!cancelled() &&
needs.check-should-run.outputs.should-run == 'true' &&
needs.determine-framework-tests-scope.result == 'success' &&
needs.determine-framework-tests-scope.outputs.framework-tests-scope == 'all' &&
Expand Down Expand Up @@ -675,7 +675,7 @@ jobs:
testcafe-jquery:
needs: [check-should-run, build-devextreme, determine-framework-tests-scope, determine-jquery-test-matrix]
if: |
always() &&
!cancelled() &&
needs.check-should-run.outputs.should-run == 'true' &&
needs.determine-framework-tests-scope.result == 'success' &&
needs.determine-jquery-test-matrix.result == 'success' &&
Expand Down Expand Up @@ -833,7 +833,7 @@ jobs:
testcafe-frameworks-all:
needs: [check-should-run, determine-framework-tests-scope, build-demos]
if: |
always() &&
!cancelled() &&
needs.check-should-run.outputs.should-run == 'true' &&
needs.determine-framework-tests-scope.result == 'success' &&
needs.determine-framework-tests-scope.outputs.framework-tests-scope == 'all' &&
Expand Down Expand Up @@ -981,7 +981,7 @@ jobs:
testcafe-frameworks-changed:
needs: [check-should-run, determine-framework-tests-scope, build-demos]
if: |
always() &&
!cancelled() &&
needs.check-should-run.outputs.should-run == 'true' &&
needs.determine-framework-tests-scope.result == 'success' &&
needs.determine-framework-tests-scope.outputs.framework-tests-scope == 'changed' &&
Expand Down Expand Up @@ -1107,7 +1107,7 @@ jobs:
merge-artifacts:
runs-on: ubuntu-latest
needs: [testcafe-jquery, testcafe-frameworks-all, testcafe-frameworks-changed]
if: always() && (needs.testcafe-jquery.result == 'failure' || needs.testcafe-frameworks-all.result == 'failure' || needs.testcafe-frameworks-changed.result == 'failure')
if: ${{ !cancelled() && (needs.testcafe-jquery.result == 'failure' || needs.testcafe-frameworks-all.result == 'failure' || needs.testcafe-frameworks-changed.result == 'failure') }}

steps:
- name: Merge jQuery screenshot artifacts
Expand Down Expand Up @@ -1159,7 +1159,7 @@ jobs:
name: CSP check (jQuery)
needs: [check-should-run, build-devextreme]
if: |
always() &&
!cancelled() &&
needs.check-should-run.outputs.should-run == 'true' &&
needs.build-devextreme.result == 'success'
runs-on: devextreme-shr2
Expand Down Expand Up @@ -1232,7 +1232,7 @@ jobs:
name: ${{ matrix.SHARD_TOTAL == 1 && format('CSP check ({0})', matrix.FRAMEWORK) || format('CSP check ({0} {1}/{2})', matrix.FRAMEWORK, matrix.SHARD_INDEX, matrix.SHARD_TOTAL) }}
needs: [check-should-run, determine-framework-tests-scope, build-devextreme]
if: |
always() &&
!cancelled() &&
needs.check-should-run.outputs.should-run == 'true' &&
needs.determine-framework-tests-scope.result == 'success' &&
needs.determine-framework-tests-scope.outputs.framework-tests-scope != 'none' &&
Expand Down Expand Up @@ -1331,7 +1331,7 @@ jobs:
name: CSP Violations Summary
runs-on: ubuntu-latest
needs: [check-should-run, csp-check-jquery, csp-check-frameworks]
if: always() && needs.check-should-run.outputs.should-run == 'true'
if: ${{ !cancelled() && needs.check-should-run.outputs.should-run == 'true' }}
timeout-minutes: 5

steps:
Expand Down
Loading