Repository navigation
Globalize demo - fix accessibility labels - #35511
Open
flagmanAndrew wants to merge 4 commits into
Open
flagmanAndrew wants to merge 4 commits into
flagmanAndrew wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The shared editor options incorrectly label popup Amount fields as “Filter cell” across all five variants.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates accessibility labels in the Globalize localization demos and removes two demo-test accessibility exceptions.
Changes:
- Adds “Filter cell” labels to Amount editor options across five framework variants.
- Removes rule exceptions for two DataGrid demos.
| File | Description |
|---|---|
| apps/demos/testing/common.test.ts | Removes two accessibility exceptions. |
| apps/demos/Demos/Localization/UsingGlobalize/Vue/App.vue | Adds the Amount editor label. |
| apps/demos/Demos/Localization/UsingGlobalize/ReactJs/App.js | Adds the Amount editor label. |
| apps/demos/Demos/Localization/UsingGlobalize/React/App.tsx | Adds the Amount editor label. |
| apps/demos/Demos/Localization/UsingGlobalize/jQuery/index.js | Adds the Amount editor label. |
| apps/demos/Demos/Localization/UsingGlobalize/Angular/app/app.component.html | Adds the Amount editor label. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and also remove redundant accessibility exceptions